Skip to content

Conversation

@mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Nov 7, 2025

The macos-13 runners are deprecated and will disappear by end of 2025. Replacement: macos-15-intel.

@mkoeppe

This comment was marked as resolved.

@mkoeppe mkoeppe changed the title Update GH Actions macOS runner, update cibuildwheel for Python 3.14 build Update GH Actions macOS runner, update cibuildwheel for Python 3.14 build, add support for Cython 3.1.x Nov 7, 2025
@mkoeppe mkoeppe requested a review from tkralphs November 7, 2025 05:09
@mkoeppe mkoeppe changed the title Update GH Actions macOS runner, update cibuildwheel for Python 3.14 build, add support for Cython 3.1.x Update GH Actions macOS runner, update cibuildwheel for Python 3.14 build, add support for Cython 3.1.x, 3.2.x Nov 12, 2025
@tkralphs
Copy link
Member

tkralphs commented Dec 2, 2025

Thanks for this @mkoeppe and sorry for the delay in looking at it. I just glanced at it now and it looks good, but there are some failing test. Glancing at those, they look to be CVXPy issues, not CyLP issues. Any ideas how to get then passing?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 2, 2025

they look to be CVXPy issues, not CyLP issues. Any ideas how to get then passing?

I'd suggest to run the GH Actions workflow on the master branch to check the baseline. I'm not sure if we're pinning CVXPy for these tests; likely it's caused by a CVXPy update or other updated packages

@tkralphs
Copy link
Member

tkralphs commented Dec 2, 2025

Indeed, the result is the same in master. The problem seems to be cvxpy is being imported from site-packages (/Library/Frameworks/Python.framework/.../cvxpy), but pytest is trying to collect tests from the local development directory (/Users/runner/work/CyLP/CyLP/cvxpy). This creates a conflict because the same module exists in both places. But I don't really know what changed because it looks like it should not have been working before either. I opened #224 to try to fix this.

@tkralphs
Copy link
Member

tkralphs commented Dec 2, 2025

Indeed, running the tests from the installed cvxpy with python -m pytest --pyargs cvxpy.tests fixed the issue. But cvxpy requires numpy 2 now, while we were explicitly testing CyLP with numpy 1.26 just for good measure. So testing with numpy 1.26 is now failing because of dependency conflicts. I think it is easy to allow backwards compatibility with older numpy versions, so I wish cvxpy had done that, but I guess I can just disable that test for now.

@tkralphs tkralphs closed this Dec 3, 2025
@tkralphs tkralphs reopened this Dec 3, 2025
@tkralphs
Copy link
Member

tkralphs commented Dec 3, 2025

I merged #224 and then tried to rebase your branch, but for some reason, I can't push to it, even though this PR is open. Instead, I just opened and closed the PR to re-run tests. If you want to rebase on master and force push, that might be cleaner.

@mkoeppe mkoeppe force-pushed the cibuildwheel-3.2.1 branch from 8270d8f to 158edf6 Compare December 3, 2025 04:01
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 3, 2025

Rebased.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 3, 2025

I merged #224 and then tried to rebase your branch, but for some reason, I can't push to it

Might be because I opened the PR from an org repository, rather than a personal repository

@tkralphs
Copy link
Member

tkralphs commented Dec 3, 2025

Looks good now!

@tkralphs tkralphs merged commit cada9af into coin-or:master Dec 3, 2025
10 checks passed
@mkoeppe mkoeppe deleted the cibuildwheel-3.2.1 branch December 3, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants