Skip to content

Invalid package.xml suppresses error and silently succeeds if setup.py present #146

Description

@emersonknapp

If you have a package with both package.xml and setup.py - if the package.xml has invalid syntax, then colcon build silently falls back to a regular python build type, without even printing a warning.

I would expect this to actually fail the build, as it's a pretty serious error condition with confusing side effects. Instead it's only logged as a debug.

# COLCON_LOG_LEVEL=debug colcon build --packages-select mypkg
...
[0.216s] DEBUG:colcon.colcon_core.package_identification:Failed to parse potential ROS package manifest in'src/mypkg': Error(s) in package 'src/mypkg/package.xml':                                                                                     
The manifest contains invalid XML:                                                                                                                                                                                                                            
mismatched tag: line 4, column 12  
...
# echo $?
0

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions