Commit d1feab0
authored
fix(adapters): bump telegramify-markdown to 1.3.3 for blockquote escaping (#1340)
* fix(adapters): bump telegramify-markdown to 1.3.3 for blockquote escaping
telegramify-markdown 1.3.2 escapes the `>` blockquote marker (which
Telegram MarkdownV2 supports natively) and double-escapes any other
special character on the same line, so any blockquote ending in a
period (or containing `.`, `!`, `-`, etc.) is rejected by the Bot
API with "Character '.' is reserved and must be escaped". The bot
falls back to plain text and logs telegram.markdownv2_failed.
Upstream fixed both bugs in 1.3.3. Bumping the floor to ^1.3.3 and
adding a regression test on the canonical "> hi." case so the
behaviour can't silently regress if the dependency loosens later.
Fixes #1102
* test(adapters): broaden blockquote regression with multi-char and multi-line cases
Addresses review nit on #1340. 1.3.2's bug regressed both on multiple
special characters on one line and on multi-line blockquotes, so pinning
those shapes down adds real confidence against a future re-regression.
Expected outputs verified against telegramify-markdown 1.3.3:
- `> a.b-c!` escapes `.`, `-`, `!` exactly once, `>` marker unescaped.
- `> first.\n> second?` escapes `.` once, `?` passes through (not in
Telegram MarkdownV2's reserved set), `>` marker unescaped on both lines.
* test(adapters): reframe blockquote regression comment around bug behavior
Address review on #1340: drop version-number framing in favor of
describing the bug behavior. Version numbers rot as the floor moves;
the bug behavior plus the issue link stays stable.1 parent a7f8ae1 commit d1feab0
3 files changed
Lines changed: 21 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
70 | 88 | | |
71 | 89 | | |
72 | 90 | | |
| |||
0 commit comments