Skip to content

Commit a2dc500

Browse files
Remove checks for six.PY2.
1 parent 40bcc0f commit a2dc500

9 files changed

Lines changed: 2 additions & 45 deletions

File tree

src/collective/easyform/actions.py

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@
6060
from zope.schema import Bool
6161
from zope.schema import getFieldsInOrder
6262
from zope.security.interfaces import IPermission
63-
import six
6463

6564

6665
logger = getLogger("collective.easyform")
@@ -356,8 +355,6 @@ def get_header_row(self):
356355
titles = self.getColumnTitles()
357356
encoded_titles = []
358357
for t in titles:
359-
if six.PY2 and isinstance(t, str):
360-
t = t.encode("utf-8")
361358
encoded_titles.append(t)
362359
return encoded_titles
363360

@@ -409,8 +406,6 @@ def get_attachments(self, fields, request):
409406
if sendCSV or sendXLSX:
410407
if not is_file_data(field):
411408
val = self.serialize(field)
412-
if six.PY2:
413-
val = val.encode("utf-8")
414409
csvdata += (val,)
415410

416411
if sendXML:
@@ -479,8 +474,6 @@ def get_mail_text(self, fields, request, context):
479474
"""Get header and body of e-mail as text (string)"""
480475
headerinfo = self.get_header_info(fields, request, context)
481476
body = self.get_mail_body(fields, request, context)
482-
if six.PY2 and isinstance(body, str):
483-
body = body.encode("utf-8")
484477
email_charset = "utf-8"
485478
# always use text/plain for encrypted bodies
486479
subtype = (
@@ -521,7 +514,7 @@ def get_mail_text(self, fields, request, context):
521514
maintype, subtype = ctype.split("/", 1)
522515

523516
if maintype == "text":
524-
if not six.PY2 and isinstance(content, bytes):
517+
if isinstance(content, bytes):
525518
content = content.decode("utf-8")
526519
msg = MIMEText(content, _subtype=subtype)
527520
elif maintype == "image":
@@ -535,8 +528,6 @@ def get_mail_text(self, fields, request, context):
535528
encoders.encode_base64(msg)
536529

537530
# Set the filename parameter
538-
if six.PY2 and isinstance(filename, str):
539-
filename = filename.encode("utf-8")
540531
msg.add_header(
541532
"Content-Disposition", "attachment", filename=("utf-8", "", filename)
542533
)
@@ -585,8 +576,6 @@ def getScript(self, context):
585576
if role != "none":
586577
script.manage_proxy((role,))
587578

588-
if six.PY2 and isinstance(body, str):
589-
body = body.encode("utf-8")
590579
params = "fields, easyform, request"
591580
script.ZPythonScript_edit(params, body)
592581
return script
@@ -688,8 +677,6 @@ def get_header_row(self):
688677
titles = self.getColumnTitles()
689678
encoded_titles = []
690679
for t in titles:
691-
if six.PY2 and isinstance(t, str):
692-
t = t.encode("utf-8")
693680
encoded_titles.append(t)
694681
return encoded_titles
695682

@@ -702,12 +689,8 @@ def get_data(row, i):
702689
return data.raw
703690
if is_file_data(data):
704691
data = data.filename
705-
if six.PY2 and isinstance(data, str):
706-
return data.encode("utf-8")
707692
if isinstance(data, (list, tuple, set)):
708693
data = '|'.join(data)
709-
if six.PY2:
710-
return data.encode('utf-8')
711694
return data
712695

713696
return [get_data(row, i) for i in names]

src/collective/easyform/api.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
from re import compile
1717
from zope.schema import getFieldsInOrder
1818

19-
import six
20-
2119

2220
CONTEXT_KEY = "context"
2321
# regular expression for dollar-sign variable replacement.
@@ -94,9 +92,6 @@ def get_expression(context, expression_string, **kwargs):
9492
:param dict kwargs: additional arguments for expression
9593
:returns: result of TALES expression
9694
"""
97-
if six.PY2 and isinstance(expression_string, str):
98-
expression_string = expression_string.encode("utf-8")
99-
10095
expression_context = getExprContext(context, context)
10196
for key in kwargs:
10297
expression_context.setGlobal(key, kwargs[key])
@@ -249,9 +244,6 @@ def cleanup(value):
249244
if isinstance(value, (list, tuple)):
250245
value = [safe_text(s).strip() for s in value]
251246

252-
if six.PY2:
253-
# py2 expects a list of bytes
254-
value = [s.encode("utf-8") for s in value if s]
255247
return value
256248

257249

src/collective/easyform/browser/view.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@
3838
from zope.schema import ValidationError
3939
from ZPublisher.mapply import mapply
4040

41-
import six
42-
4341

4442
logger = getLogger("collective.easyform")
4543
PMF = MessageFactory("plone")
@@ -198,8 +196,6 @@ def handleSubmit(self, action):
198196
return
199197
thanksPageOverrideAction = self.context.thanksPageOverrideAction
200198
thanksPage = get_expression(self.context, thanksPageOverride)
201-
if six.PY2 and isinstance(thanksPage, str):
202-
thanksPage = thanksPage.encode("utf-8")
203199
if thanksPageOverrideAction == "redirect_to":
204200
self.request.response.redirect(thanksPage)
205201
return
@@ -366,8 +362,6 @@ def header_injection(self):
366362
if not tal_expression:
367363
return ""
368364
header_to_inject = get_expression(self.context, tal_expression)
369-
if six.PY2 and isinstance(header_to_inject, str):
370-
header_to_inject = header_to_inject.encode("utf-8")
371365

372366
return header_to_inject
373367

src/collective/easyform/interfaces/fields.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
from zope.schema.interfaces import IContextSourceBinder
2020
from zope.schema.vocabulary import SimpleVocabulary
2121

22-
import six
2322
import z3c.form.interfaces
2423
import zope.interface
2524
import zope.schema.interfaces

src/collective/easyform/migration/fields.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
from Products.PloneFormGen.interfaces import IPloneFormGenFieldset
77

88
import logging
9-
import six
109

1110

1211
logger = logging.getLogger("collective.easyform.migration")
@@ -149,8 +148,6 @@ def to_text(value):
149148
if isinstance(value, (list, tuple)):
150149
return [to_text(v) for v in value]
151150
value = str(value)
152-
if six.PY2:
153-
value = value.decode("utf8")
154151
return value
155152

156153

src/collective/easyform/tests/attachment.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ File attachments
22
================
33

44
::
5-
>>> from six import BytesIO
5+
>>> from io import BytesIO
66
>>> browser = get_browser(layer)
77

88
Add a new EasyForm::

src/collective/easyform/tests/testCustomScript.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313
from plone.app.testing import logout
1414
from Products.CMFCore import permissions
1515

16-
import six
17-
1816

1917
test_script = """
2018
## Python Script

src/collective/easyform/tests/testLikert.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import unittest
2-
import six
32

43
from collective.easyform.tests.base import EasyFormFunctionalTestCase
54
from zope.schema.interfaces import RequiredMissing

src/collective/easyform/validators.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@
1111
from z3c.form import validator
1212

1313

14-
import six
15-
16-
1714
BAD_SIGNS = frozenset(["<a ", "www.", "http:", ".com", "https:"])
1815

1916

@@ -71,8 +68,6 @@ def validate(value, **kwargs):
7168
if value is None:
7269
# Let the system for required take care of None values
7370
return
74-
if six.PY2 and isinstance(value, str):
75-
value = value.encode("utf-8")
7671
res = validation(name, value, **kwargs)
7772
if res != 1:
7873
return res

0 commit comments

Comments
 (0)