Skip to content

Commit 59ba838

Browse files
Remove redundant self.pop() calls as suggested by niccokunzmann
- Remove self.pop('DTEND', None) before self.DURATION = assignments - Remove self.pop('DUE', None) before self.DURATION = assignments - The DURATION property setter automatically handles mutual exclusion - Simplifies code as requested in review feedback
1 parent 8d29c90 commit 59ba838

2 files changed

Lines changed: 0 additions & 10 deletions

File tree

src/icalendar/cal/event.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,6 @@ def set_duration(
409409
if "DURATION" in self:
410410
return # Already has DURATION property
411411
current_duration = self.duration
412-
self.pop("DTEND", None)
413412
self.DURATION = current_duration
414413
return
415414

@@ -427,12 +426,10 @@ def set_duration(
427426
# Keep start locked, adjust end
428427
if start is None:
429428
raise IncompleteComponent("No DTSTART given.")
430-
self.pop("DTEND", None)
431429
self.DURATION = duration
432430
elif locked == "end":
433431
# Keep end locked, adjust start
434432
current_end = self.end
435-
self.pop("DTEND", None)
436433
self.DTSTART = current_end - duration
437434
self.DURATION = duration
438435
else:
@@ -465,7 +462,6 @@ def set_start(
465462
)
466463
self.DTSTART = start
467464
if current_duration is not None:
468-
self.pop("DTEND", None)
469465
self.DURATION = current_duration
470466
elif locked == "end":
471467
# Keep end locked, adjust duration
@@ -494,7 +490,6 @@ def set_end(
494490
elif locked == "duration":
495491
# Keep duration locked, adjust start
496492
current_duration = self.duration
497-
self.pop("DTEND", None)
498493
self.DTSTART = end - current_duration
499494
self.DURATION = current_duration
500495
else:

src/icalendar/cal/todo.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,6 @@ def set_duration(
261261
if "DURATION" in self:
262262
return # Already has DURATION property
263263
current_duration = self.duration
264-
self.pop("DUE", None)
265264
self.DURATION = current_duration
266265
return
267266

@@ -279,12 +278,10 @@ def set_duration(
279278
# Keep start locked, adjust end
280279
if start is None:
281280
raise IncompleteComponent("No DTSTART given.")
282-
self.pop("DUE", None)
283281
self.DURATION = duration
284282
elif locked == "end":
285283
# Keep end locked, adjust start
286284
current_end = self.end
287-
self.pop("DUE", None)
288285
self.DTSTART = current_end - duration
289286
self.DURATION = duration
290287
else:
@@ -317,7 +314,6 @@ def set_start(
317314
)
318315
self.DTSTART = start
319316
if current_duration is not None:
320-
self.pop("DUE", None)
321317
self.DURATION = current_duration
322318
elif locked == "end":
323319
# Keep end locked, adjust duration
@@ -346,7 +342,6 @@ def set_end(
346342
elif locked == "duration":
347343
# Keep duration locked, adjust start
348344
current_duration = self.duration
349-
self.pop("DUE", None)
350345
self.DTSTART = end - current_duration
351346
self.DURATION = current_duration
352347
else:

0 commit comments

Comments
 (0)