Skip to content

Commit c3c6269

Browse files
committed
Merge branch 'main' of https://github.com/colmap/glomap into user/jsch/view-graph-simplifcation
2 parents 4b8a229 + 351ac10 commit c3c6269

File tree

5 files changed

+55
-15
lines changed

5 files changed

+55
-15
lines changed

.github/workflows/mac.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
matrix:
1818
config: [
1919
{
20-
os: macos-14,
20+
os: macos-15,
2121
arch: arm64,
2222
cmakeBuildType: Release,
2323
},

.github/workflows/windows.yml

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,7 @@ jobs:
1717
matrix:
1818
config: [
1919
{
20-
os: windows-2022,
21-
cmakeBuildType: Release,
22-
cudaEnabled: true,
23-
testsEnabled: true,
24-
exportPackage: true,
25-
},
26-
{
27-
os: windows-2022,
20+
os: windows-2025,
2821
cmakeBuildType: Release,
2922
cudaEnabled: false,
3023
testsEnabled: true,
@@ -37,13 +30,13 @@ jobs:
3730
COMPILER_CACHE_DIR: ${{ github.workspace }}/compiler-cache
3831
CCACHE_DIR: ${{ github.workspace }}/compiler-cache/ccache
3932
CCACHE_BASEDIR: ${{ github.workspace }}
40-
VCPKG_COMMIT_ID: bc3512a509f9d29b37346a7e7e929f9a26e66c7e
33+
VCPKG_COMMIT_ID: 2ad7bd06128280e02bfe02361d8ffd7d465cfcf0
4134
GLOG_v: 1
4235
GLOG_logtostderr: 1
4336

4437
steps:
4538
- uses: actions/checkout@v4
46-
39+
4740
# We define the vcpkg binary sources using separate variables for read and
4841
# write operations:
4942
# * Read sources are defined as inline. These can be read by anyone and,
@@ -74,7 +67,7 @@ jobs:
7467
key: v${{ env.COMPILER_CACHE_VERSION }}-${{ matrix.config.os }}-${{ matrix.config.cmakeBuildType }}-${{ matrix.config.asanEnabled }}--${{ matrix.config.cudaEnabled }}-${{ github.run_id }}-${{ github.run_number }}
7568
restore-keys: v${{ env.COMPILER_CACHE_VERSION }}-${{ matrix.config.os }}-${{ matrix.config.cmakeBuildType }}-${{ matrix.config.asanEnabled }}--${{ matrix.config.cudaEnabled }}
7669
path: ${{ env.COMPILER_CACHE_DIR }}
77-
70+
7871
- name: Install ccache
7972
shell: pwsh
8073
run: |

CMakeLists.txt

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,17 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
2020

2121
set_property(GLOBAL PROPERTY GLOBAL_DEPENDS_NO_CYCLES ON)
2222

23+
# Determine project compiler.
24+
if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
25+
set(IS_MSVC TRUE)
26+
endif()
27+
if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
28+
set(IS_GNU TRUE)
29+
endif()
30+
if(CMAKE_CXX_COMPILER_ID MATCHES ".*Clang")
31+
set(IS_CLANG TRUE)
32+
endif()
33+
2334
include(cmake/FindDependencies.cmake)
2435

2536
if (TESTS_ENABLED)
@@ -45,8 +56,7 @@ else()
4556
message(STATUS "Disabling ccache support")
4657
endif()
4758

48-
49-
if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
59+
if(IS_MSVC)
5060
# Some fixes for the Glog library.
5161
add_definitions("-DGLOG_USE_GLOG_EXPORT")
5262
add_definitions("-DGLOG_NO_ABBREVIATED_SEVERITIES")
@@ -62,4 +72,5 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
6272
endif()
6373
endif()
6474

75+
add_subdirectory(thirdparty)
6576
add_subdirectory(glomap)

glomap/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ if(MSVC)
9696
else()
9797
target_compile_options(glomap PRIVATE
9898
-Wall
99-
-Werror
10099
-Wno-sign-compare
101100
-Wno-unused-variable
102101
)

thirdparty/CMakeLists.txt

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
if(IS_GNU OR IS_CLANG)
2+
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -w")
3+
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -w")
4+
endif()
5+
6+
include(FetchContent)
7+
8+
FetchContent_Declare(poselib
9+
GIT_REPOSITORY https://github.com/PoseLib/PoseLib.git
10+
GIT_TAG f119951fca625133112acde48daffa5f20eba451
11+
EXCLUDE_FROM_ALL
12+
SYSTEM
13+
)
14+
message(STATUS "Configuring PoseLib...")
15+
if(FETCH_POSELIB)
16+
set(MARCH_NATIVE OFF CACHE BOOL "")
17+
FetchContent_MakeAvailable(poselib)
18+
else()
19+
find_package(PoseLib REQUIRED)
20+
endif()
21+
message(STATUS "Configuring PoseLib... done")
22+
23+
FetchContent_Declare(COLMAP
24+
GIT_REPOSITORY https://github.com/colmap/colmap.git
25+
GIT_TAG b6b7b54eca6078070f73a3f0a084f79c629a6f10 # Nov 20, 2025
26+
EXCLUDE_FROM_ALL
27+
SYSTEM
28+
)
29+
message(STATUS "Configuring COLMAP...")
30+
set(UNINSTALL_ENABLED OFF CACHE INTERNAL "")
31+
set(GUI_ENABLED OFF CACHE INTERNAL "")
32+
if (FETCH_COLMAP)
33+
FetchContent_MakeAvailable(COLMAP)
34+
else()
35+
find_package(COLMAP REQUIRED)
36+
endif()
37+
message(STATUS "Configuring COLMAP... done")

0 commit comments

Comments
 (0)