Skip to content

Commit db5bb79

Browse files
committed
f
1 parent 8818b41 commit db5bb79

File tree

3 files changed

+12
-17
lines changed

3 files changed

+12
-17
lines changed

glomap/controllers/rotation_averager_test.cc

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
#include "glomap/controllers/global_mapper.h"
21
#include "glomap/controllers/rotation_averager.h"
2+
3+
#include "glomap/controllers/global_mapper.h"
34
#include "glomap/estimators/gravity_refinement.h"
45
#include "glomap/io/colmap_io.h"
56
#include "glomap/math/rigid3d.h"
@@ -48,13 +49,13 @@ void PrepareGravity(const colmap::Reconstruction& gt,
4849
if (outlier_ratio > 0.0 && double(rand()) / RAND_MAX < outlier_ratio) {
4950
Eigen::Quaterniond q;
5051
CreateRandomRotation(1., q);
51-
gravity = Rigid3dToAngleAxis(Rigid3d(q, Eigen::Vector3d::Zero())).normalized();
52+
gravity =
53+
Rigid3dToAngleAxis(Rigid3d(q, Eigen::Vector3d::Zero())).normalized();
5254
}
5355
images[image_id].gravity_info.SetGravity(gravity);
5456
}
5557
}
5658

57-
5859
GlobalMapperOptions CreateMapperTestOptions() {
5960
GlobalMapperOptions options;
6061
options.skip_view_graph_calibration = false;
@@ -75,11 +76,9 @@ RotationAveragerOptions CreateRATestOptions(bool use_gravity = false) {
7576
return options;
7677
}
7778

78-
void ExpectEqualRotations(
79-
const colmap::Reconstruction& gt,
80-
const colmap::Reconstruction& computed,
81-
const double max_rotation_error_deg) {
82-
79+
void ExpectEqualRotations(const colmap::Reconstruction& gt,
80+
const colmap::Reconstruction& computed,
81+
const double max_rotation_error_deg) {
8382
const std::set<image_t> reg_image_ids_set = gt.RegImageIds();
8483
std::vector<image_t> reg_image_ids(reg_image_ids_set.begin(),
8584
reg_image_ids_set.end());
@@ -115,7 +114,6 @@ void ExpectEqualGravity(
115114

116115
double gravity_error_deg = CalcAngle(gravity_gt, gravity_computed);
117116
EXPECT_LT(gravity_error_deg, max_gravity_error_deg);
118-
119117
}
120118
}
121119

@@ -199,7 +197,6 @@ TEST(RotationEstimator, WithNoiseAndOutliers) {
199197
ExpectEqualRotations(
200198
gt_reconstruction, reconstruction, /*max_rotation_error_deg=*/2.);
201199
}
202-
203200
}
204201

205202
TEST(RotationEstimator, RefineGravity) {
@@ -224,20 +221,18 @@ TEST(RotationEstimator, RefineGravity) {
224221
ConvertDatabaseToGlomap(database, view_graph, cameras, images);
225222

226223
// PrepareRelativeRotations(view_graph, images);
227-
PrepareGravity(gt_reconstruction, images, /*stddev_gravity=*/0., /*outlier_ratio=*/0.3);
224+
PrepareGravity(
225+
gt_reconstruction, images, /*stddev_gravity=*/0., /*outlier_ratio=*/0.3);
228226

229227
GlobalMapper global_mapper(CreateMapperTestOptions());
230228
global_mapper.Solve(database, view_graph, cameras, images, tracks);
231229

232-
233230
GravityRefinerOptions opt_grav_refine;
234231
GravityRefiner grav_refiner(opt_grav_refine);
235232
grav_refiner.RefineGravity(view_graph, images);
236233

237234
// Check whether the gravity does not have error after refinement
238235
ExpectEqualGravity(gt_reconstruction, images, /*max_gravity_error_deg=*/1e-2);
239-
240-
241236
}
242237

243238
} // namespace

glomap/math/gravity.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,7 @@ Eigen::Vector3d AverageGravity(const std::vector<Eigen::Vector3d>& gravities) {
9292

9393
double CalcAngle(const Eigen::Vector3d& gravity1,
9494
const Eigen::Vector3d& gravity2) {
95-
double cos_r = gravity1.dot(gravity2) /
96-
(gravity1.norm() * gravity2.norm());
95+
double cos_r = gravity1.dot(gravity2) / (gravity1.norm() * gravity2.norm());
9796
cos_r = std::min(std::max(cos_r, -1.), 1.);
9897

9998
return std::acos(cos_r) * 180 / EIGEN_PI;

glomap/math/gravity.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,6 @@ Eigen::Matrix3d AngleToRotUp(double angle);
1717
// Estimate the average gravity direction from a set of gravity directions
1818
Eigen::Vector3d AverageGravity(const std::vector<Eigen::Vector3d>& gravities);
1919

20-
double CalcAngle(const Eigen::Vector3d& gravity1, const Eigen::Vector3d& gravity2);
20+
double CalcAngle(const Eigen::Vector3d& gravity1,
21+
const Eigen::Vector3d& gravity2);
2122
} // namespace glomap

0 commit comments

Comments
 (0)