fix: incorrect phpstan-type for Mutations TDataSet parameter (#271)

taka-oyama · web-flow · commit e86fa4780fe3 · 2025-04-07T13:00:17.000+09:00
diff --git a/src/Concerns/ManagesMutations.php b/src/Concerns/ManagesMutations.php
@@ -29,7 +29,7 @@
 use InvalidArgumentException;
 
 /**
- * @phpstan-type TDataSet list<array<string, array<array-key, mixed>>>|array<string, array<array-key, mixed>>
+ * @phpstan-type TDataSet list<array<string, mixed>>|array<string, mixed>
  */
 trait ManagesMutations
 {
@@ -129,7 +129,7 @@ protected function prepareForMutation(array $dataSet): array
             return [];
         }
 
-        if (Arr::isAssoc($dataSet)) {
+        if (!array_is_list($dataSet)) {
             $dataSet = [$dataSet];
         }
 

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@`
`29`	`29`	`use InvalidArgumentException;`
`30`	`30`
`31`	`31`	`/**`
`32`		`- * @phpstan-type TDataSet list<array<string, array<array-key, mixed>>>\|array<string, array<array-key, mixed>>`
	`32`	`+ * @phpstan-type TDataSet list<array<string, mixed>>\|array<string, mixed>`
`33`	`33`	`*/`
`34`	`34`	`trait ManagesMutations`
`35`	`35`	`{`
`@@ -129,7 +129,7 @@ protected function prepareForMutation(array $dataSet): array`
`129`	`129`	`return [];`
`130`	`130`	`}`
`131`	`131`
`132`		`- if (Arr::isAssoc($dataSet)) {`
	`132`	`+ if (!array_is_list($dataSet)) {`
`133`	`133`	`$dataSet = [$dataSet];`
`134`	`134`	`}`
`135`	`135`