Skip to content

refactor getPrivateStream to allow multiple filter #331

Open
@gleizesDor

Description

@gleizesDor

give predicate as a parameter :

public static Stream<Object> getPrivateStream(List<TPrivate> privates, Predicate<TPrivate> predicate) {
        return privates
                .stream()
                .filter(predicate)
                .map(TAnyContentFromOtherNamespace::getContent)
                .flatMap(List::stream)
                .filter(JAXBElement.class::isInstance)
                .map(JAXBElement.class::cast)
                .filter(Predicate.not(JAXBElement::isNil))
                .map(JAXBElement::getValue);
    }

Refactor all calls to other "getPrivateStream" method

Here is the test :

@Test
    void getPrivate_should_filter() {
        //Given
        Predicate<TPrivate> icdHeaderPredicate = tPrivate -> "COMPAS-SclFileType".equals(tPrivate.getType());
        Predicate<TPrivate> systemVersionPredicate = tPrivate -> "COMPAS-SystemVersion".equals(tPrivate.getType());
        Predicate<TPrivate> predicate = icdHeaderPredicate.or(systemVersionPredicate);

        //When
        Stream<Object> privateStream = PrivateUtils.getPrivateStream(List.of(privateSCD, privateICD), predicate);
        
        //Then
        assertThat(privateStream.toList()).isNotEmpty();
    }

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    Status

    To do

    Status

    To do

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions