Skip to content

Commit 54d8083

Browse files
committed
Fix forcetypeassert linter violations in data_source_test.go
Unchecked type assertions (x.(T)) are flagged by the forcetypeassert linter enabled in .golangci.yml. Use the comma-ok pattern with require.True, matching the pattern already used in resource_helpers_test.go. https://claude.ai/code/session_01RGuqEJbEyQYff6DAr5nst1
1 parent 702842c commit 54d8083

1 file changed

Lines changed: 12 additions & 4 deletions

File tree

internal/provider/data_source_test.go

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,18 @@ func TestMapRunnerToDataSourceModel_MapsAllFields(t *testing.T) {
6161
assert.Equal(t, int64(12), got.Spec.Configuration.UpdateWindow.EndHour.ValueInt64())
6262

6363
statusAttrs := got.Status.Attributes()
64-
assert.Equal(t, string(gitpod.RunnerPhaseDegraded), statusAttrs["phase"].(types.String).ValueString())
65-
assert.Equal(t, "degraded", statusAttrs["message"].(types.String).ValueString())
66-
assert.Equal(t, "1.2.3", statusAttrs["version"].(types.String).ValueString())
67-
assert.Equal(t, "eu-central-1", statusAttrs["region"].(types.String).ValueString())
64+
phase, ok := statusAttrs["phase"].(types.String)
65+
require.True(t, ok)
66+
assert.Equal(t, string(gitpod.RunnerPhaseDegraded), phase.ValueString())
67+
message, ok := statusAttrs["message"].(types.String)
68+
require.True(t, ok)
69+
assert.Equal(t, "degraded", message.ValueString())
70+
version, ok := statusAttrs["version"].(types.String)
71+
require.True(t, ok)
72+
assert.Equal(t, "1.2.3", version.ValueString())
73+
region, ok := statusAttrs["region"].(types.String)
74+
require.True(t, ok)
75+
assert.Equal(t, "eu-central-1", region.ValueString())
6876
}
6977

7078
func TestMapRunnerToDataSourceModel_NullOptionalFields(t *testing.T) {

0 commit comments

Comments
 (0)