fix misra errors for safety.c

Author: aubsw

board/drivers/registers.h

@@ -1,4 +1,5 @@
 #include "registers_declarations.h"
+#include "safety/board/faults_declarations.h"
 
 static reg register_map[REGISTER_MAP_SIZE];
 

board/faults.h

@@ -36,9 +36,3 @@
 
 // Permanent faults
 #define PERMANENT_FAULTS 0U
-
-extern uint8_t fault_status;
-extern uint32_t faults;
-
-extern void fault_occurred(uint32_t fault);
-extern void fault_recovered(uint32_t fault);

board/safety.c

@@ -8,8 +8,12 @@ extern void print(const char *a);
 extern void puth(unsigned int i);
 extern uint32_t microsecond_timer_get(void);
 
+// Suppress funky header inclusion ordering. We need the forward declarations
+// above. This will all eventually be deleted when opendbc is fixed.
+// cppcheck-suppress-begin misra-c2012-20.1 -
 #include "safety/board/utils.h"
 #include "safety/board/faults.h"
 #include "safety/board/can.h"
 #include "safety/board/drivers/can_common.h"
 #include "safety/safety.h"
+// cppcheck-suppress-end misra-c2012-20.1

tests/misra/checkers.txt

@@ -5,7 +5,7 @@ Cppcheck checkers list from test_misra.sh:
 
 
 TEST variant options:
---enable=all --disable=unusedFunction -DPANDA --addon=misra -DSTM32F4 -DSTM32F413xx /board/ --enable=all --file-filter=*.c -i /board/safety.c -i /board/jungle/main.c -i /board/bootstub.c
+--enable=all --disable=unusedFunction -DPANDA --addon=misra -DSTM32F4 -DSTM32F413xx /board/ --enable=all --file-filter=*.c -i /board/jungle/main.c -i /board/bootstub.c
 
 
 Critical errors
@@ -460,7 +460,7 @@ Not available, Cppcheck Premium is not used
 
 
 TEST variant options:
---enable=all --disable=unusedFunction -DPANDA --addon=misra -DSTM32H7 -DSTM32H725xx /board/ --enable=all --file-filter=*.c -i /board/safety.c -i /board/jungle/main.c -i /board/bootstub.c
+--enable=all --disable=unusedFunction -DPANDA --addon=misra -DSTM32H7 -DSTM32H725xx /board/ --enable=all --file-filter=*.c -i /board/jungle/main.c -i /board/bootstub.c
 
 
 Critical errors

tests/misra/test_misra.sh

@@ -73,9 +73,8 @@ cppcheck() {
 
 PANDA_OPTS="--enable=all --disable=unusedFunction -DPANDA --addon=misra"
 PANDA_SOURCES="$PANDA_DIR/board/ --enable=all --file-filter=*.c \
-         -i $PANDA_DIR/board/safety.c \
          -i $PANDA_DIR/board/jungle/main.c \
-         -i $PANDA_DIR/board/bootstub.c"
+         -i $PANskA_DIR/board/bootstub.c"
 
 printf "\n${GREEN}** PANDA F4 CODE **${NC}\n"
 cppcheck $PANDA_OPTS -DSTM32F4 -DSTM32F413xx $PANDA_SOURCES