garbage collect always-true condition check (#2305)

jyoung8607 · web-flow · commit f373c69bbb3d · 2025-12-10T13:00:20.000-08:00
garbage collect dead code
diff --git a/board/drivers/usb.h b/board/drivers/usb.h
@@ -502,11 +502,8 @@ static void usb_setup(void) {
       control_req.length = setup.b.wLength.w;
 
       resp_len = comms_control_handler(&control_req, response);
-      // response pending if -1 was returned
-      if (resp_len != -1) {
-        USB_WritePacket(response, MIN(resp_len, setup.b.wLength.w), 0);
-        USBx_OUTEP(0U)->DOEPCTL |= USB_OTG_DOEPCTL_CNAK;
-      }
+      USB_WritePacket(response, MIN(resp_len, setup.b.wLength.w), 0);
+      USBx_OUTEP(0U)->DOEPCTL |= USB_OTG_DOEPCTL_CNAK;
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -502,11 +502,8 @@ static void usb_setup(void) {`
`502`	`502`	`control_req.length = setup.b.wLength.w;`
`503`	`503`
`504`	`504`	`resp_len = comms_control_handler(&control_req, response);`
`505`		`- // response pending if -1 was returned`
`506`		`- if (resp_len != -1) {`
`507`		`- USB_WritePacket(response, MIN(resp_len, setup.b.wLength.w), 0);`
`508`		`- USBx_OUTEP(0U)->DOEPCTL \|= USB_OTG_DOEPCTL_CNAK;`
`509`		`- }`
	`505`	`+ USB_WritePacket(response, MIN(resp_len, setup.b.wLength.w), 0);`
	`506`	`+ USBx_OUTEP(0U)->DOEPCTL \|= USB_OTG_DOEPCTL_CNAK;`
`510`	`507`	`}`
`511`	`508`	`}`
`512`	`509`