Skip to content

Toyota: SecOC longitudinal control safety#2072

Closed
jyoung8607 wants to merge 6 commits intocommaai:masterfrom
jyoung8607:secoc-long
Closed

Toyota: SecOC longitudinal control safety#2072
jyoung8607 wants to merge 6 commits intocommaai:masterfrom
jyoung8607:secoc-long

Conversation

@jyoung8607
Copy link
Copy Markdown
Collaborator

@jyoung8607 jyoung8607 commented Nov 1, 2024

Complement to commaai/opendbc#1385, intended to progress (not necessarily replace) #2061.

  • opendbc needs a corresponding change to send inactive accel in ACC_CONTROL
  • common test override is lame, can we do better?
  • do we actually need the radar diagnostic address when we're able to MITM?
    • Radar diagnostic is permitted for all Toyota long right now, should scope better but not in this PR

@jyoung8607 jyoung8607 marked this pull request as draft November 1, 2024 20:23
@sshane
Copy link
Copy Markdown
Contributor

sshane commented Feb 20, 2025

We've moved the car safety code into opendbc, please rebase and re-open your PR there!

@sshane sshane closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants