Skip to content

Hyundai: Synchronize flag names#2101

Closed
sunnyhaibin wants to merge 1 commit intocommaai:masterfrom
sunnypilot:sync-flag-names
Closed

Hyundai: Synchronize flag names#2101
sunnyhaibin wants to merge 1 commit intocommaai:masterfrom
sunnypilot:sync-flag-names

Conversation

@sunnyhaibin
Copy link
Copy Markdown
Contributor

@sunnyhaibin sunnyhaibin commented Dec 10, 2024

Description

  • Refactor flag names in Hyundai safety to make them more descriptive and consistent.
  • Variable names starting with HYUNDAI_PARAM_ have been updated to start with FLAG_HYUNDAI_.
  • The functionality remains unchanged; only the naming has been updated for improved clarity and readability.
  • This change helps maintain a standardized naming convention across the Python and C++ codebase, making future development and debugging easier.
  • No logic or functional behavior of the code is altered in this PR.

panda/python/__init__.py

Lines 197 to 204 in bedee40

FLAG_HYUNDAI_EV_GAS = 1
FLAG_HYUNDAI_HYBRID_GAS = 2
FLAG_HYUNDAI_LONG = 4
FLAG_HYUNDAI_CAMERA_SCC = 8
FLAG_HYUNDAI_CANFD_HDA2 = 16
FLAG_HYUNDAI_CANFD_ALT_BUTTONS = 32
FLAG_HYUNDAI_ALT_LIMITS = 64
FLAG_HYUNDAI_CANFD_HDA2_ALT_STEERING = 128

@sshane
Copy link
Copy Markdown
Contributor

sshane commented Feb 20, 2025

We've moved the car safety code into opendbc, please rebase and re-open your PR there!

@sshane sshane closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants