Conversation
The 2025 Kia Carnival w/ HDA2 uses ALT_BUTTONS.
7e78791 to
a8d208d
Compare
|
I think this is ready for review. For the reviewer: at first glance, you will probably wonder "why refactor the tests just to add a test case?" I did this in order to handle the combinatorial nature of hyundai configs1 in a balanced way — neither copy-pasting large chunks nor making test code so complex that it deserves its own tests. For reference, subaru and honda are using similar patterns (e.g. dedupe Footnotes
|
a8d208d to
0401f64
Compare
This is needed for the Kia Caravan '25.
b1a5e7b to
a09c1cc
Compare
|
We've moved the car safety code into opendbc, please rebase and re-open your PR there! |
Issues fixed:
Testing:
Routes:
Related: