Refactor: separate driver declarations (.h) from implementations (.c)#2381
Closed
m4rba4s wants to merge 3 commits into
Closed
Refactor: separate driver declarations (.h) from implementations (.c)#2381m4rba4s wants to merge 3 commits into
m4rba4s wants to merge 3 commits into
Conversation
m4rba4s
force-pushed
the
refactor-headers
branch
5 times, most recently
from
2018389 to
28b704d
Compare
m4rba4s
force-pushed
the
refactor-headers
branch
11 times, most recently
from
0e6c735 to
a76d46c
Compare
m4rba4s
force-pushed
the
refactor-headers
branch
from
a76d46c to
c255b97
Compare
…lation - Segregated Panda, Jungle, and Body firmware into independent build targets - Fixed duplicate symbol definitions across heterogeneous hardware targets - Implemented robust SCons build system with explicit compilation/linking stages - Resolved MISRA-C 2012 violations and linker script conflicts - Validated all firmware binaries and functional tests (USB protocol) Resolves commaai#2171
Author
|
naive guy? right?
damn fuck
autonomous driving firmware, not a toy web app. If you merge a sloppy,
fragmented refactoring job just to close the bounty, a car is going to
stall on the highway after 30k miles because of a corrupted header link or
a nasty dependency loop
…On Wed, Apr 8, 2026 at 12:36 PM Adeeb Shihadeh ***@***.***> wrote:
Closed #2381 <#2381>.
—
Reply to this email directly, view it on GitHub
<#2381 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BTMOEBZMFL6PNAUZCM5H3SL4UZ5ZVAVCNFSM6AAAAACXMTWP5GVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRUGMYDGNJSGMYDINA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2171