Skip to content

Hongqi HS5#882

Closed
jyoung8607 wants to merge 32 commits intocommaai:masterfrom
jyoung8607:faw-hongqi-hs5
Closed

Hongqi HS5#882
jyoung8607 wants to merge 32 commits intocommaai:masterfrom
jyoung8607:faw-hongqi-hs5

Conversation

@jyoung8607
Copy link
Copy Markdown
Collaborator

@jyoung8607 jyoung8607 commented Mar 21, 2022

Work in progress, mostly there. TODO:

  • CC button (set/resume and cancel button handling), need to work this out in opendbc first
  • verify ABS wheel speed signal scaling, current value is approximated
  • confirm driver input torque threshold is reasonable
  • explore factory EPS limits
  • replay route

This passes CI testing locally, but won't pass in GitHub CI until the opendbc PR is merged and bumped in openpilot.

@jyoung8607 jyoung8607 mentioned this pull request Mar 21, 2022
21 tasks
@adeebshihadeh adeebshihadeh added the car safety vehicle-specific safety code label Mar 21, 2022
@jyoung8607 jyoung8607 changed the title FAW: Hongqi HS5 Hongqi HS5 Aug 24, 2022
@jyoung8607
Copy link
Copy Markdown
Collaborator Author

@robbederks @briskspirit It looks like part of the H7/Red Panda memory map is on the fine edge of overflowing. I've started having problems building this PR. Everything seems fine if I comment out a couple other unrelated safety modes. I don't know what happens if the H7 memory map is modified, or if it's even possible to modify.

/* Specify the memory areas */
MEMORY
{
DTCMRAM (xrw) : ORIGIN = 0x20000000, LENGTH = 128K
RAM_D1 (xrw) : ORIGIN = 0x24000000, LENGTH = 320K
RAM_D2 (xrw) : ORIGIN = 0x30000000, LENGTH = 32K
RAM_D3 (xrw) : ORIGIN = 0x38000000, LENGTH = 16K
ITCMRAM (xrw) : ORIGIN = 0x00000000, LENGTH = 64K
FLASH (rx) : ORIGIN = 0x8000000, LENGTH = 1024K
}
.

image

@briskspirit
Copy link
Copy Markdown
Contributor

Will increase memory available size on Monday

@briskspirit
Copy link
Copy Markdown
Contributor

Should be fixed on master, "freed" ~28Kb

@jyoung8607
Copy link
Copy Markdown
Collaborator Author

Should be fixed on master, "freed" ~28Kb

Looks good now, thank you!

@sshane
Copy link
Copy Markdown
Contributor

sshane commented Feb 20, 2025

We've moved the car safety code into opendbc, please rebase and re-open your PR there!

@sshane sshane closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

car safety vehicle-specific safety code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants