Closed
Conversation
21 tasks
# Conflicts: # Dockerfile.panda
Collaborator
Author
|
@robbederks @briskspirit It looks like part of the H7/Red Panda memory map is on the fine edge of overflowing. I've started having problems building this PR. Everything seems fine if I comment out a couple other unrelated safety modes. I don't know what happens if the H7 memory map is modified, or if it's even possible to modify. panda/board/stm32h7/stm32h7x5_flash.ld Lines 64 to 73 in f56ebf5 |
Contributor
|
Will increase memory available size on Monday |
Contributor
|
Should be fixed on master, "freed" ~28Kb |
Collaborator
Author
Looks good now, thank you! |
Contributor
|
We've moved the car safety code into opendbc, please rebase and re-open your PR there! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Work in progress, mostly there. TODO:
This passes CI testing locally, but won't pass in GitHub CI until the opendbc PR is merged and bumped in openpilot.