Make suggested changes from review

Author: mpurnell1

.github/workflows/pages.yml

@@ -33,11 +33,6 @@ jobs:
           bun install
           bun run build
 
-      # To deploy to a custom domain (e.g. flashpack.comma.ai),
-      # uncomment this step and configure DNS to point to GitHub Pages
-      # - name: set custom domain
-      #   run: echo "flashpack.comma.ai" > tools/flashpack/dist/CNAME
-
       - name: configure pages
         uses: actions/configure-pages@v5
 

tools/flashpack/build.ts

@@ -1,8 +1,13 @@
+const gitSha = Bun.spawnSync(["git", "rev-parse", "HEAD"]).stdout.toString().trim();
+
 const build = await Bun.build({
   entrypoints: ["./src/index.html"],
   outdir: "./dist",
   sourcemap: "linked",
   minify: true,
+  define: {
+    "process.env.GIT_SHA": JSON.stringify(gitSha),
+  },
 });
 
 if (!build.success) {

tools/flashpack/setup-udev.sh

@@ -1,7 +1,7 @@
 import { FlashManager, Step, ErrorCode, loadProgrammer } from "./utils/manager";
 import { getManifest } from "./utils/manifest";
 
-import portsThree from "./assets/qdl-ports-three.svg";
+import portsThree from "./assets/qdl-ports-threex.svg";
 import portsFour from "./assets/qdl-ports-four.svg";
 import comma3X from "./assets/comma3X.webp";
 import commaFour from "./assets/four_screen_on.webp";
@@ -333,11 +333,16 @@ async function init() {
   $("init-status").textContent = "loading programmer + manifest...";
 
   try {
-    const [programmer, manifest] = await Promise.all([
+    const [programmer, { version, manifest }] = await Promise.all([
       loadProgrammer(),
       getManifest(),
     ]);
 
+    const sha = process.env.GIT_SHA || "master";
+    const versionLink = document.getElementById("version-link") as HTMLAnchorElement;
+    versionLink.href = `https://github.com/commaai/vamOS/tree/${sha}`;
+    versionLink.textContent = sha.slice(0, 7);
+
     console.info("[flashpack] Manifest loaded:", manifest.length, "entries");
     manager = new FlashManager(programmer, {});
     await manager.initialize(manifest);
@@ -346,7 +351,7 @@ async function init() {
       throw new Error("Initialization failed");
     }
 
-    $("init-status").textContent = `ready! (${manager.step === Step.READY ? "manifest loaded" : "..."})`;
+    $("init-status").textContent = "";
     ($("btn-start") as HTMLButtonElement).disabled = false;
   } catch (err: any) {
     console.error("[flashpack] Init failed:", err);