Fix comments from code review

Author: tdeekens

typescript/src/ai-sdk/__tests__/essentials.test.ts

@@ -144,9 +144,9 @@ describe('CommercetoolsAgentEssentials with Admin tools', () => {
       toolFormat
     );
 
-    expect(Object.keys(agentEssentials.tools)).toContain('tool1');
-    expect(Object.keys(agentEssentials.tools)).toContain('tool2');
-    expect(Object.keys(agentEssentials.tools)).not.toContain('tool3');
+    expect(Object.keys(agentEssentials.getTools())).toContain('tool1');
+    expect(Object.keys(agentEssentials.getTools())).toContain('tool2');
+    expect(Object.keys(agentEssentials.getTools())).not.toContain('tool3');
   });
 
   it('should return all created tools via getTools method', () => {
@@ -193,6 +193,6 @@ describe('CommercetoolsAgentEssentials with Admin tools', () => {
 
     expect(isToolAllowed).toHaveBeenCalledTimes(tools.length);
     expect(CommercetoolsTool).not.toHaveBeenCalled();
-    expect(Object.keys(agentEssentials.tools).length).toBe(0);
+    expect(Object.keys(agentEssentials.getTools()).length).toBe(0);
   });
 });

typescript/src/mastra/__tests__/essentials.test.ts

@@ -145,9 +145,9 @@ describe('CommercetoolsAgentEssentials with Mastra', () => {
       toolFormat
     );
 
-    expect(Object.keys(agentEssentials.tools)).toContain('tool1');
-    expect(Object.keys(agentEssentials.tools)).toContain('tool2');
-    expect(Object.keys(agentEssentials.tools)).not.toContain('tool3');
+    expect(Object.keys(agentEssentials.getTools())).toContain('tool1');
+    expect(Object.keys(agentEssentials.getTools())).toContain('tool2');
+    expect(Object.keys(agentEssentials.getTools())).not.toContain('tool3');
   });
 
   it('should return all created tools via getTools method', () => {
@@ -194,7 +194,7 @@ describe('CommercetoolsAgentEssentials with Mastra', () => {
 
     expect(isToolAllowed).toHaveBeenCalledTimes(tools.length);
     expect(CommercetoolsTool).not.toHaveBeenCalled();
-    expect(Object.keys(agentEssentials.tools).length).toBe(0);
+    expect(Object.keys(agentEssentials.getTools()).length).toBe(0);
   });
 
   it('should store tools as an object with method names as keys', () => {

typescript/src/mastra/essentials.ts

@@ -12,8 +12,7 @@ import {AuthConfig} from '../types/auth';
 
 class CommercetoolsAgentEssentials {
   private _commercetools: CommercetoolsAPI;
-
-  tools: {[key: string]: Tool};
+  private _tools: {[key: string]: Tool} = {};
 
   constructor({
     authConfig,
@@ -29,12 +28,10 @@ class CommercetoolsAgentEssentials {
       processedConfiguration.context
     );
 
-    this.tools = {};
-
     contextToTools(processedConfiguration.context)
       .filter((tool) => isToolAllowed(tool, processedConfiguration))
       .forEach((tool) => {
-        this.tools[tool.method] = CommercetoolsTool(
+        this._tools[tool.method] = CommercetoolsTool(
           this._commercetools,
           tool.method,
           tool.description,
@@ -45,7 +42,7 @@ class CommercetoolsAgentEssentials {
   }
 
   getTools(): {[key: string]: Tool} {
-    return this.tools;
+    return this._tools;
   }
 }