Skip to content

Conversation

@ragafus
Copy link
Contributor

@ragafus ragafus commented Dec 23, 2025

Summary

react-redux v9 already ships its own types. @types/react-redux is a left over from the past.

See https://github.com/reduxjs/react-redux/releases/tag/v8.0.0

Description

While trying to upgrade the monorepo to redux v5 and react-redux v9, I spotted the deprecated types coming from the app-kit dependencies.

@ragafus ragafus self-assigned this Dec 23, 2025
@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2025

🦋 Changeset detected

Latest commit: 53c5903

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@commercetools-frontend/react-notifications Patch
@commercetools-frontend/application-shell Patch
@commercetools-frontend/actions-global Patch
@commercetools-frontend/sdk Patch
@commercetools-local/visual-testing-app Patch
@commercetools-frontend/cypress Patch
@commercetools-applications/merchant-center-template-starter-typescript Patch
@commercetools-applications/merchant-center-template-starter Patch
@commercetools-applications/merchant-center-custom-view-template-starter-typescript Patch
@commercetools-applications/merchant-center-custom-view-template-starter Patch
@commercetools-local/playground Patch
@commercetools-frontend/application-components Patch
@commercetools-frontend/codemod Patch
@commercetools-frontend/mc-scripts Patch
@commercetools-website/components-playground Patch
@commercetools-backend/eslint-config-node Patch
@commercetools-backend/express Patch
@commercetools-backend/loggers Patch
@commercetools-frontend/application-config Patch
@commercetools-frontend/application-shell-connectors Patch
@commercetools-frontend/assets Patch
@commercetools-frontend/babel-preset-mc-app Patch
@commercetools-frontend/browser-history Patch
@commercetools-frontend/constants Patch
@commercetools-frontend/create-mc-app Patch
@commercetools-frontend/eslint-config-mc-app Patch
@commercetools-frontend/i18n Patch
@commercetools-frontend/jest-preset-mc-app Patch
@commercetools-frontend/jest-stylelint-runner Patch
@commercetools-frontend/l10n Patch
@commercetools-frontend/mc-dev-authentication Patch
@commercetools-frontend/mc-html-template Patch
@commercetools-frontend/notifications Patch
@commercetools-frontend/permissions Patch
@commercetools-frontend/sentry Patch
@commercetools-frontend/url-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
mc-app-kit-playground Ready Ready Preview, Comment Dec 23, 2025 2:55pm
merchant-center-application-kit-components-playground Ready Ready Preview, Comment Dec 23, 2025 2:55pm

Copy link
Contributor

@valoriecarli valoriecarli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.06%. Comparing base (22862f6) to head (53c5903).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3908   +/-   ##
=======================================
  Coverage   75.06%   75.06%           
=======================================
  Files         260      260           
  Lines        6361     6361           
  Branches     2007     1979   -28     
=======================================
  Hits         4775     4775           
  Misses       1565     1565           
  Partials       21       21           
Components Coverage Δ
Application Components 81.18% <ø> (ø)
Application Shell 74.41% <ø> (ø)
Application Shell Connectors 77.54% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22862f6...53c5903. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ragafus ragafus merged commit 51a854a into main Dec 23, 2025
21 checks passed
@ragafus ragafus deleted the rg-drop-types-react-redux branch December 23, 2025 15:02
@ct-changesets ct-changesets bot mentioned this pull request Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants