Skip to content

Downgrade jsondiffpatcher to v0.5.0 prior becoming ESM only #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tdeekens
Copy link
Contributor

@tdeekens tdeekens commented May 6, 2025

Summary

In the major release of packages of this repository in #1930 the jsondiffpatcher library was bumped to v0.6.0. This version however is ESM only.

Screenshot 2025-05-06 at 21 01 34@2x

That version is also the last version with a good release note. The ESM only mode may work for Node.js environments as all supported environments support ESM but can fail in browsers and testing environments.

As this library doesn't rely on specifics of the jsondiffpatcher library we can consider downgrading.

The proceeding of this will be discussed internally.

Copy link

changeset-bot bot commented May 6, 2025

⚠️ No Changeset found

Latest commit: 4183353

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.55%. Comparing base (f27d3a8) to head (4183353).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1964   +/-   ##
=======================================
  Coverage   98.55%   98.55%           
=======================================
  Files         111      111           
  Lines        2904     2904           
  Branches      834      834           
=======================================
  Hits         2862     2862           
  Misses         40       40           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant