Skip to content

Commit 2024330

Browse files
committed
Fix DeprecationWarning: Nesting argument groups is deprecated.
This was making the pytest output very noisy. Also update the help test as the `--cid-*` options work for both the Docker and Podman container engines.
1 parent 119ff7e commit 2024330

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

cwltool/argparser.py

+3-5
Original file line numberDiff line numberDiff line change
@@ -415,9 +415,7 @@ def arg_parser() -> argparse.ArgumentParser:
415415
dest="rm_container",
416416
)
417417

418-
cidgroup = container_group.add_argument_group(
419-
"Recording the Docker container identifier into a file"
420-
)
418+
cidgroup = parser.add_argument_group("Recording the software container identifier into a file")
421419
cidgroup.add_argument(
422420
# Disabled as containerid is now saved by default
423421
"--record-container-id",
@@ -430,15 +428,15 @@ def arg_parser() -> argparse.ArgumentParser:
430428
cidgroup.add_argument(
431429
"--cidfile-dir",
432430
type=str,
433-
help="Store the Docker container ID into a file in the specified directory.",
431+
help="Store the software container ID into a file in the specified directory.",
434432
default=None,
435433
dest="cidfile_dir",
436434
)
437435

438436
cidgroup.add_argument(
439437
"--cidfile-prefix",
440438
type=str,
441-
help="Specify a prefix to the container ID filename. "
439+
help="Specify a prefix to the software container ID filename. "
442440
"Final file name will be followed by a timestamp. "
443441
"The default is no prefix.",
444442
default=None,

0 commit comments

Comments
 (0)