Skip to content

[Clang-tidy] Narrowing data types is implementation defined #437

Open
@alvarogarcia7

Description

@alvarogarcia7

Clang-Tidy: Narrowing conversion from 'unsigned char' to signed type 'char' is implementation-defined

const unsigned char *eol;
S_is_line_end_char(*eol)

where S_is_line_end_char is defined as:

static CMARK_INLINE bool S_is_line_end_char(char c) {
  return (c == '\n' || c == '\r');
}

I'm sending a PR to fix it as well.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions