Unit tests failing for prodRelease flavor

[nicolas-raoul]

> Task :app:compileProdReleaseUnitTestKotlin FAILED
e: app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionsListFragmentUnitTests.kt:5:30 Unresolved reference: testing
e: app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionsListFragmentUnitTests.kt:6:30 Unresolved reference: testing
e: app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionsListFragmentUnitTests.kt:33:36 Unresolved reference: FragmentScenario
e: app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionsListFragmentUnitTests.kt:46:13 Unresolved reference: launchFragmentInContainer
e: app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionsListFragmentUnitTests.kt:60:13 Unresolved reference: it
e: app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionsListFragmentUnitTests.kt:60:16 Variable expected
e: app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionsListFragmentUnitTests.kt:196:13 Unresolved reference: it
e: app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionsListFragmentUnitTests.kt:212:13 Unresolved reference: it
e: app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionsListFragmentUnitTests.kt:228:13 Unresolved reference: it
e: app/src/test/kotlin/fr/free/nrw/commons/navtab/MoreBottomSheetLoggedOutFragmentUnitTests.kt:4:30 Unresolved reference: testing
e: app/src/test/kotlin/fr/free/nrw/commons/navtab/MoreBottomSheetLoggedOutFragmentUnitTests.kt:5:30 Unresolved reference: testing
e: app/src/test/kotlin/fr/free/nrw/commons/navtab/MoreBottomSheetLoggedOutFragmentUnitTests.kt:21:36 Unresolved reference: FragmentScenario
e: app/src/test/kotlin/fr/free/nrw/commons/navtab/MoreBottomSheetLoggedOutFragmentUnitTests.kt:26:13 Unresolved reference: launchFragmentInContainer
e: app/src/test/kotlin/fr/free/nrw/commons/navtab/MoreBottomSheetLoggedOutFragmentUnitTests.kt:38:31 Unresolved reference: it
e: app/src/test/kotlin/fr/free/nrw/commons/navtab/MoreBottomSheetLoggedOutFragmentUnitTests.kt:45:31 Unresolved reference: it
e: app/src/test/kotlin/fr/free/nrw/commons/navtab/MoreBottomSheetLoggedOutFragmentUnitTests.kt:52:31 Unresolved reference: it
e: app/src/test/kotlin/fr/free/nrw/commons/navtab/MoreBottomSheetLoggedOutFragmentUnitTests.kt:59:31 Unresolved reference: it

[rohit9625]

Is this on main or on each PR?

[nicolas-raoul]

When running the unit tests locally, on main.

[rohit9625]

Okay, would you mind checking PRs that fix recent crashes? #6218 #6220

[rohit9625]

I found the issue. Could you please assign me @nicolas-raoul?

[rohit9625]

The issue is only in two test files, i.e., ContributionsListFragmentUnitTests & MoreBottomSheetLoggedOutFragmentUnitTests, when accessing FragmentScenario, which works on Android environments only.

We have this dependency for debug variant only:

apps-android-commons/app/build.gradle

Line 122 in fa24b93

debugImplementation("androidx.fragment:fragment-testing:1.6.2")

Changing it to testImplementation solved the Unresolved reference issue, but tests on those two files start failing for both prodDebug and prodRelease.

However, those tests don't look like UnitTests. Can we move them to androidTest, @nicolas-raoul?