Skip to content

Commit 0cdf087

Browse files
Migrated from "label: enhancement" to "Type: feature" (#59)
* Migrated from enhancement to feature * Migrated from enhancement to feature * Fix: minor changes * Fix: minor changes * Fix: Migrate from enhancement to feature
1 parent e4108a6 commit 0cdf087

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

android/Code-style.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ In short, please discuss things with us before you submit a PR with a new librar
3434

3535
## Architecture
3636

37-
Please follow the [MVP architecture](https://github.com/commons-app/apps-android-commons/issues/888) if you are submitting a large enhancement (definitions of "large" vary according to context - if you are not sure whether this is needed for your code, ask beforehand)
37+
Please follow the [MVP architecture](https://github.com/commons-app/apps-android-commons/issues/888) if you are submitting a large feature (definitions of "large" vary according to context - if you are not sure whether this is needed for your code, ask beforehand)
3838

3939
## Unit tests
4040

41-
Please write unit tests to cover your own code if you are submitting an enhancement (i.e. the issue that you are working on has an "enhancement" label)
41+
Please write unit tests to cover your own code if you are submitting a feature (i.e. the issue that you are working on has a "Feature" type)
4242

4343
## Logging
4444

android/Contributing-Guidelines.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ You **must**:
1010
- Add Javadocs to all new methods and classes that you create
1111
- Follow correct procedures if adding a new library (additions of new libraries must always be discussed and approved beforehand)
1212
- Escape HTML tags in strings
13-
- Write unit tests to cover your own code if you are submitting an enhancement (the issue that you are working on has an "enhancement" label)
14-
- Follow the [MVP architecture](https://github.com/commons-app/apps-android-commons/issues/888) if you are submitting a large enhancement (definitions of "large" vary according to context - if you are not sure whether this is needed for your code, ask beforehand)
13+
- Write unit tests to cover your own code if you are submitting a feature (the issue that you are working on has a "Feature" type)
14+
- Follow the [MVP architecture](https://github.com/commons-app/apps-android-commons/issues/888) if you are submitting a large feature (definitions of "large" vary according to context - if you are not sure whether this is needed for your code, ask beforehand)
1515

1616
You should also:
1717
- Follow the [Google Java Style Guide](https://google.github.io/styleguide/javaguide.html)
@@ -102,7 +102,7 @@ format, or this invocation of "git show":
102102
Read the importance of commit message in the [linked blog](https://blog.oozou.com/commit-messages-matter-60309983c227?gi=c550a10d0f67).
103103
### Write tests for your code (if possible)
104104

105-
When adding a new feature or submitting an enhancement, make sure that you have written unit tests to show
105+
When adding a new feature, make sure that you have written unit tests to show
106106
the feature triggers the new behavior when it should, and to show the
107107
feature does not trigger when it shouldn't. After any code change, make
108108
sure that the entire test suite passes.

android/Project-maintenance.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ We also have a [LinkedIn page](https://www.linkedin.com/company/wikimedia-common
6161

6262
- Every major release (e.g. 2.6) should be pulled from main and a new branch created (e.g. `2.6.x-release`)
6363
- Hotfixes to the major release must be done in the `2.6.x-release` branch, not in main
64-
- Hotfix releases (e.g. 2.6.1) will be pulled from the `2.6.x-release` branch. New changes/enhancements to main will not be included in the hotfix release
64+
- Hotfix releases (e.g. 2.6.1) will be pulled from the `2.6.x-release` branch. New changes/features to main will not be included in the hotfix release
6565
- Release branches will be merged into main periodically (so main is up to date with hotfixes made to release branches)
6666
- Hotfixes can be released to production after being tested in beta for a few days. Major releases on the other hand should be tested in beta for a much longer time (e.g. 2 weeks?)
6767

android/Volunteers-welcome!.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ We are always looking for volunteers, feel free to step in! It's very easy to ge
66

77
1. Set up your working environment by following the [quick start guide](Quick-start-guide-for-Developers.md).
88
2. Choose an [unassigned bug](https://github.com/commons-app/apps-android-commons/issues?q=is%3Aissue%20state%3Aopen%20type%3ABug%20no%3Aassignee%20-label%3A%22low%20priority%22%20-label%3Adebated%20-label%3Aupstream) that sounds interesting to you, and ask to be assigned the issue. If the issue was assigned to someone who has been inactive for over 1 month, you can bring this to the attention of collaborators who may ping them for updates and possibly re-assign the issue to you.
9-
- If you are a new contributor, please only ask to be assigned to issues with a "bug" or "good first issue" label. Issues labeled "enhancement" will usually only be assigned to contributors with **more than 5 merged pull requests** to this repo. Exceptions may be granted if multiple collaborators agree, but it will take time for approval. ([rationale](https://github.com/commons-app/apps-android-commons/issues/2553))
9+
- If you are a new contributor, please only ask to be assigned to issues with a "Bug" type or "good first issue" label. Issues of type "Feature" will usually only be assigned to contributors with **more than 5 merged pull requests** to this repo. Exceptions may be granted if multiple collaborators agree, but it will take time for approval. ([rationale](https://github.com/commons-app/apps-android-commons/issues/2553))
1010
4. Follow the [Contributing Guidelines](Contributing-Guidelines.md).
1111

1212
It is also recommended that you actually try the app and upload pictures with the app. Become familiar with the various workflows. Notice what kind of categories are suggested depending on where the picture is taken or what you type. Check what people consider [excellent pictures](https://commons.wikimedia.org/wiki/Commons:Featured_pictures) and get inspired by their rich descriptions and accurate categories.

android/gsoc.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ Thank you for your interest! In the candidate selection phase of GSoC, we ask yo
4141
- Project Technologies: Android, Java, Kotlin, SQL
4242
- Project Topics: UI, UX, database
4343
8. (_Optionally, you can fix more bugs, and add them to your proposal_)
44-
9. (_Optionally, after 5 bugfixes, you can also work on enhancements, and add them to your proposal. Please stay aware that quality is better than quantity, though._)
44+
9. (_Optionally, after 5 bugfixes, you can also work on features, and add them to your proposal. Please stay aware that quality is better than quantity, though._)
4545

4646
<!--
4747
# Task ideas

0 commit comments

Comments
 (0)