Skip to content

Commit 5c222f2

Browse files
hjmjohnsonclaude
andcommitted
COMP: Fix local variable naming in ctkMacroBuildLibWrapper
Rename my_EXTRA_Python3_LIBRARIES back to my_EXTRA_PYTHON_LIBRARIES. This is a local variable (not a CMake module output), so using the Python3_ prefix creates confusion about whether it comes from FindPython3. The local naming convention uses PYTHON (uppercase). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 1913d8d commit 5c222f2

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

CMake/ctkMacroBuildLibWrapper.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ macro(ctkMacroBuildLibWrapper)
9696
# these ones to avoid complaints of MSVC
9797
# Note: "LINK_DIRECTORIES" has to be invoked before "ADD_LIBRARY"
9898
ctkFunctionExtractOptimizedLibrary(Python3_LIBRARIES PYTHON_LIBRARY)
99-
set(my_EXTRA_Python3_LIBRARIES ${PYTHON_LIBRARY} ${PYTHONQT_LIBRARIES})
99+
set(my_EXTRA_PYTHON_LIBRARIES ${PYTHON_LIBRARY} ${PYTHONQT_LIBRARIES})
100100

101101
# Does a header having the expected filename exists ?
102102
string(REGEX REPLACE "^CTK" "ctk" lib_name_lc_ctk ${lib_name})
@@ -122,7 +122,7 @@ macro(ctkMacroBuildLibWrapper)
122122
list(APPEND KIT_PYTHONQT_SRCS ${DECORATOR_HEADER})
123123
endif()
124124
add_library(${lib_name}PythonQt ${MY_WRAPPER_LIBRARY_TYPE} ${KIT_PYTHONQT_SRCS})
125-
target_link_libraries(${lib_name}PythonQt ${lib_name} ${my_EXTRA_Python3_LIBRARIES})
125+
target_link_libraries(${lib_name}PythonQt ${lib_name} ${my_EXTRA_PYTHON_LIBRARIES})
126126
if(MY_WRAPPER_LIBRARY_TYPE STREQUAL "STATIC")
127127
if(CMAKE_SIZEOF_VOID_P EQUAL 8) # 64-bit
128128
set_target_properties(${lib_name}PythonQt PROPERTIES COMPILE_FLAGS "-fPIC")

0 commit comments

Comments
 (0)