COMP: Replace QDir assignment with setPath() (#1248)

hjmjohnson · web-flow · commit 5f750c8822b6 · 2025-07-15T02:45:35.000Z
Avoids direct QDir object assignments in `ctkDirectoryButton`, using
`setPath()` instead for improved compatibility and clarity.
diff --git a/Libs/Widgets/ctkDirectoryButton.cpp b/Libs/Widgets/ctkDirectoryButton.cpp
@@ -116,7 +116,7 @@ ctkDirectoryButton::ctkDirectoryButton(const QString& dir,
 {
   Q_D(ctkDirectoryButton);
   d->init();
-  d->Directory = QDir(dir);
+  d->Directory.setPath(dir);
   d->PushButton->setText(d->DisplayAbsolutePath ? d->Directory.absolutePath() : d->Directory.path());
   d->PushButton->setIcon(this->style()->standardIcon(QStyle::SP_DirIcon));
 }
@@ -129,7 +129,7 @@ ctkDirectoryButton::ctkDirectoryButton(
 {
   Q_D(ctkDirectoryButton);
   d->init();
-  d->Directory = QDir(dir);
+  d->Directory.setPath(dir);
   d->PushButton->setText(d->DisplayAbsolutePath ? d->Directory.absolutePath() : d->Directory.path());
   d->PushButton->setIcon(icon);
 }
@@ -153,7 +153,7 @@ void ctkDirectoryButton::setDirectory(const QString& dir)
     return;
   }
 
-  d->Directory = newDirectory;
+  d->Directory.setPath(newDirectory.absolutePath());
   d->updateDisplayText();
 
   emit directorySelected(d->DisplayAbsolutePath ?

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ ctkDirectoryButton::ctkDirectoryButton(const QString& dir,`
`116`	`116`	`{`
`117`	`117`	`Q_D(ctkDirectoryButton);`
`118`	`118`	`d->init();`
`119`		`- d->Directory = QDir(dir);`
	`119`	`+ d->Directory.setPath(dir);`
`120`	`120`	`d->PushButton->setText(d->DisplayAbsolutePath ? d->Directory.absolutePath() : d->Directory.path());`
`121`	`121`	`d->PushButton->setIcon(this->style()->standardIcon(QStyle::SP_DirIcon));`
`122`	`122`	`}`
`@@ -129,7 +129,7 @@ ctkDirectoryButton::ctkDirectoryButton(`
`129`	`129`	`{`
`130`	`130`	`Q_D(ctkDirectoryButton);`
`131`	`131`	`d->init();`
`132`		`- d->Directory = QDir(dir);`
	`132`	`+ d->Directory.setPath(dir);`
`133`	`133`	`d->PushButton->setText(d->DisplayAbsolutePath ? d->Directory.absolutePath() : d->Directory.path());`
`134`	`134`	`d->PushButton->setIcon(icon);`
`135`	`135`	`}`
`@@ -153,7 +153,7 @@ void ctkDirectoryButton::setDirectory(const QString& dir)`
`153`	`153`	`return;`
`154`	`154`	`}`
`155`	`155`
`156`		`- d->Directory = newDirectory;`
	`156`	`+ d->Directory.setPath(newDirectory.absolutePath());`
`157`	`157`	`d->updateDisplayText();`
`158`	`158`
`159`	`159`	`emit directorySelected(d->DisplayAbsolutePath ?`