STYLE: Anticipate PythonQt update migrating to Python 3 Unicode and Long APIs

Follow-up of 4513569 ("COMP: Remove Python 2.x support from PythonCore
and PythonWidget libraries", 2023-12-09) changing the code to use
Python 3's Unicode and Long APIs, in anticipation of an update to PythonQt
that will remove the older APIs.

Specifically, it replaces:
* `PyString_Check with `PyUnicode_Check`
* `PyString_AsString` with `PyUnicode_AsUTF8`
* `PyString_FromString` with `PyUnicode_FromString`
* `PyInt_AsLong` with `PyLong_AsLong`

No functional change intended.

Author: jcfr

Libs/Scripting/Python/Core/Testing/Cpp/ctkAbstractPythonManagerTest.cpp

@@ -423,9 +423,9 @@ void ctkAbstractPythonManagerTester::testPythonModule()
   }
   else
   {
-    returnedPyString = PyString_FromString("");
+    returnedPyString = PyUnicode_FromString("");
   }
-  QString returnedString = PyString_AsString(returnedPyString);
+  QString returnedString = PyUnicode_AsUTF8(returnedPyString);
   QCOMPARE(returnedString, expectedReturnedString);
 }
 
@@ -469,9 +469,9 @@ void ctkAbstractPythonManagerTester::testPythonObject()
   }
   else
   {
-    returnedPyObjectString = PyString_FromString("");
+    returnedPyObjectString = PyUnicode_FromString("");
   }
-  QString returnedString = PyString_AsString(returnedPyObjectString);
+  QString returnedString = PyUnicode_AsUTF8(returnedPyObjectString);
   QCOMPARE(returnedString, expectedReturnedString);
 }
 

Libs/Scripting/Python/Core/ctkAbstractPythonManager.cpp

@@ -370,7 +370,7 @@ QStringList ctkAbstractPythonManager::dir_object(PyObject* object,
         PyErr_Clear();
         continue;
       }
-      QString key_str(PyString_AsString(key));
+      QString key_str(PyUnicode_AsUTF8(key));
       // Append "()" if the associated object is a function
       if (appendParenthesis && PyCallable_Check(value))
       {
@@ -635,7 +635,7 @@ PyObject* ctkAbstractPythonManager::pythonObject(const QString& variableNameAndF
         {
           continue;
         }
-        QString keyStr = PyString_AsString(key);
+        QString keyStr = PyUnicode_AsUTF8(key);
         if (keyStr.operator ==(compareFunction.toLatin1()))
         {
           finalPythonObject = value;

Libs/Scripting/Python/Widgets/ctkPythonConsole.cpp

@@ -216,9 +216,9 @@ int ctkPythonConsoleCompleterPrivate::parameterCountBuiltInFunction(const QStrin
     if (PyObject_HasAttrString(pFunction, "__doc__"))
     {
       PyObject* pDoc = PyObject_GetAttrString(pFunction, "__doc__");
-      if (PyString_Check(pDoc))
+      if (PyUnicode_Check(pDoc))
       {
-        QString docString = PyString_AsString(pDoc);
+        QString docString = PyUnicode_AsUTF8(pDoc);
         QString argumentExtract = docString.mid(docString.indexOf("(")+1, docString.indexOf(")") - docString.indexOf("(")-1);
         #if (QT_VERSION >= QT_VERSION_CHECK(5, 14, 0))
         QStringList arguments = argumentExtract.split(",", Qt::SkipEmptyParts);
@@ -247,7 +247,7 @@ int ctkPythonConsoleCompleterPrivate::parameterCountUserDefinedFunction(const QS
       PyObject* ac = PyObject_GetAttrString(fc, "co_argcount");
       if (ac)
       {
-        parameterCount = PyInt_AsLong(ac);
+        parameterCount = PyLong_AsLong(ac);
         Py_DECREF(ac);
       }
       Py_DECREF(fc);
@@ -269,7 +269,7 @@ int ctkPythonConsoleCompleterPrivate::parameterCountUserDefinedClassFunction(con
       PyObject* ac = PyObject_GetAttrString(fc, "co_argcount");
       if (ac)
       {
-        parameterCount = PyInt_AsLong(ac);
+        parameterCount = PyLong_AsLong(ac);
         Py_DECREF(ac);
       }
       Py_DECREF(fc);
@@ -288,9 +288,9 @@ int ctkPythonConsoleCompleterPrivate::parameterCountFromDocumentation(const QStr
     if (PyObject_HasAttrString(pFunction, "__call__"))
     {
       PyObject* pDoc = PyObject_GetAttrString(pFunction, "__doc__");
-      if (PyString_Check(pDoc))
+      if (PyUnicode_Check(pDoc))
       {
-        QString docString = PyString_AsString(pDoc);
+        QString docString = PyUnicode_AsUTF8(pDoc);
         QString argumentExtract = docString.mid(docString.indexOf("(")+1, docString.indexOf(")") - docString.indexOf("(")-1);
         #if (QT_VERSION >= QT_VERSION_CHECK(5, 14, 0))
         QStringList arguments = argumentExtract.split(",", Qt::SkipEmptyParts);
@@ -677,28 +677,28 @@ void ctkPythonConsole::initialize(ctkAbstractPythonManager* newPythonManager)
 QString ctkPythonConsole::ps1() const
 {
   PyObject * ps1 = PySys_GetObject(const_cast<char*>("ps1"));
-  const char * ps1_str = PyString_AsString(ps1);
+  const char * ps1_str = PyUnicode_AsUTF8(ps1);
   return QLatin1String(ps1_str);
 }
 
 //----------------------------------------------------------------------------
 void ctkPythonConsole::setPs1(const QString& newPs1)
 {
-  PySys_SetObject(const_cast<char*>("ps1"), PyString_FromString(newPs1.toLatin1().data()));
+  PySys_SetObject(const_cast<char*>("ps1"), PyUnicode_FromString(newPs1.toLatin1().data()));
 }
 
 //----------------------------------------------------------------------------
 QString ctkPythonConsole::ps2() const
 {
   PyObject * ps2 = PySys_GetObject(const_cast<char*>("ps2"));
-  const char * ps2_str = PyString_AsString(ps2);
+  const char * ps2_str = PyUnicode_AsUTF8(ps2);
   return QLatin1String(ps2_str);
 }
 
 //----------------------------------------------------------------------------
 void ctkPythonConsole::setPs2(const QString& newPs2)
 {
-  PySys_SetObject(const_cast<char*>("ps2"), PyString_FromString(newPs2.toLatin1().data()));
+  PySys_SetObject(const_cast<char*>("ps2"), PyUnicode_FromString(newPs2.toLatin1().data()));
 }
 
 //----------------------------------------------------------------------------