remove reporter from application

Author: patrick-ogrady

chain/src/actors/application/actor.rs

@@ -5,7 +5,7 @@ use super::{
 };
 use crate::actors::syncer;
 use alto_types::Block;
-use commonware_cryptography::{sha256::Digest, Hasher, Sha256};
+use commonware_cryptography::{Digestible, Hasher, Sha256};
 use commonware_macros::select;
 use commonware_runtime::{Clock, Handle, Metrics, Spawner};
 use commonware_utils::SystemTimeExt;
@@ -54,7 +54,6 @@ const SYNCHRONY_BOUND: u64 = 500;
 /// Application actor.
 pub struct Actor<R: Rng + Spawner + Metrics + Clock> {
     context: R,
-    prover: Prover<Digest>,
     hasher: Sha256,
     mailbox: mpsc::Receiver<Message>,
 }
@@ -66,7 +65,6 @@ impl<R: Rng + Spawner + Metrics + Clock> Actor<R> {
         (
             Self {
                 context,
-                prover: config.prover,
                 hasher: Sha256::new(),
                 mailbox,
             },
@@ -212,26 +210,6 @@ impl<R: Rng + Spawner + Metrics + Clock> Actor<R> {
                         }
                     });
                 }
-                Message::Prepared { proof, payload } => {
-                    // Parse the proof
-                    let (view, parent, _, signature, seed) =
-                        self.prover.deserialize_notarization(proof).unwrap();
-                    let notarization = Notarization::new(view, parent, payload, signature.into());
-                    let seed = Seed::new(view, seed.into());
-
-                    // Send the notarization to the syncer
-                    syncer.notarized(notarization, seed).await;
-                }
-                Message::Finalized { proof, payload } => {
-                    // Parse the proof
-                    let (view, parent, _, signature, seed) =
-                        self.prover.deserialize_finalization(proof.clone()).unwrap();
-                    let finalization = Finalization::new(view, parent, payload, signature.into());
-                    let seed = Seed::new(view, seed.into());
-
-                    // Send the finalization to the syncer
-                    syncer.finalized(finalization, seed).await;
-                }
             }
         }
     }

chain/src/actors/application/ingress.rs

@@ -1,6 +1,6 @@
 use commonware_consensus::{
-    threshold_simplex::types::{Activity, Context, Finalization, Notarization, View},
-    Automaton, Relay, Reporter,
+    threshold_simplex::types::{Context, View},
+    Automaton, Relay,
 };
 use commonware_cryptography::sha256::Digest;
 use futures::{
@@ -26,12 +26,6 @@ pub enum Message {
         payload: Digest,
         response: oneshot::Sender<bool>,
     },
-    Notarization {
-        notarization: Notarization<Digest>,
-    },
-    Finalization {
-        finalization: Finalization<Digest>,
-    },
 }
 
 /// Mailbox for the application.
@@ -105,27 +99,3 @@ impl Relay for Mailbox {
             .expect("Failed to send broadcast");
     }
 }
-
-impl Reporter for Mailbox {
-    type Activity = Activity<Digest>;
-
-    async fn report(&mut self, activity: Self::Activity) {
-        match activity {
-            Activity::Notarization(notarization) => {
-                self.sender
-                    .send(Message::Notarization { notarization })
-                    .await
-                    .expect("Failed to send notarization");
-            }
-            Activity::Finalization(finalization) => {
-                self.sender
-                    .send(Message::Finalization { finalization })
-                    .await
-                    .expect("Failed to send finalization");
-            }
-            _ => {
-                // Ignore other activities
-            }
-        }
-    }
-}