[release] v0.0.11 (#119)

* v0.0.11

* use message received time

* fix compile error

* fix adjust time

* fix lint

* ignore skew with small absolute value

* nit

* avoid jumpy block time

* add const

* update wasm

Author: patrick-ogrady

Cargo.lock

@@ -8,8 +8,8 @@ members = [
 resolver = "2"
 
 [workspace.dependencies]
-alto-client = { version = "0.0.10", path = "client" }
-alto-types = { version = "0.0.10", path = "types" }
+alto-client = { version = "0.0.11", path = "client" }
+alto-types = { version = "0.0.11", path = "types" }
 commonware-broadcast = { version = "0.0.54" }
 commonware-codec = { version = "0.0.54" }
 commonware-consensus = { version = "0.0.54" }

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "alto-chain"
-version = "0.0.10"
+version = "0.0.11"
 publish = true
 edition = "2021"
 license = "MIT OR Apache-2.0"

chain/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "alto-client"
-version = "0.0.10"
+version = "0.0.11"
 publish = true
 edition = "2021"
 license = "MIT OR Apache-2.0"

client/Cargo.toml

@@ -1,6 +1,6 @@
 {
   "name": "alto-explorer",
-  "version": "0.0.10",
+  "version": "0.0.11",
   "private": true,
   "dependencies": {
     "@types/node": "^16.18.126",

explorer/package.json

@@ -93,6 +93,7 @@ const App: React.FC = () => {
   const handleSeedRef = useRef<typeof handleSeed>(null!);
   const handleNotarizedRef = useRef<typeof handleNotarization>(null!);
   const handleFinalizedRef = useRef<typeof handleFinalization>(null!);
+  const adjustTimeRef = useRef(adjustTime);
   const isInitializedRef = useRef(false);
   const reconnectTimeoutRef = useRef<NodeJS.Timeout | null>(null);
 
@@ -311,7 +312,7 @@ const App: React.FC = () => {
     });
   }, [lastObservedView, adjustTime]);
 
-  const handleNotarization = useCallback((notarized: NotarizedJs) => {
+  const handleNotarization = useCallback((notarized: NotarizedJs, messageReceivedTime?: number) => {
     const view = notarized.proof.view;
     setViews((prevViews) => {
       const index = prevViews.findIndex((v) => v.view === view);
@@ -320,9 +321,10 @@ const App: React.FC = () => {
       if (index !== -1 && prevViews[index].status === "finalized") {
         return prevViews; // No changes needed, preserve finalized state
       }
-
       let newViews = [...prevViews];
-      const currentTime = adjustTime(Date.now());
+
+      // If messageReceivedTime is not provided, use the current time
+      const currentTime = messageReceivedTime || adjustTime(Date.now());
 
       // Calculate a reasonable start time using the block timestamp if available
       let calculatedStartTime = currentTime;
@@ -401,12 +403,14 @@ const App: React.FC = () => {
     });
   }, [adjustTime]);
 
-  const handleFinalization = useCallback((finalized: FinalizedJs) => {
+  const handleFinalization = useCallback((finalized: FinalizedJs, messageReceivedTime?: number) => {
     const view = finalized.proof.view;
     setViews((prevViews) => {
       const index = prevViews.findIndex((v) => v.view === view);
       let newViews = [...prevViews];
-      const currentTime = adjustTime(Date.now());
+
+      // If messageReceivedTime is not provided, use the current time
+      const currentTime = messageReceivedTime || adjustTime(Date.now());
 
       // Calculate a reasonable start time using the block timestamp if available
       let calculatedStartTime = currentTime;
@@ -516,6 +520,10 @@ const App: React.FC = () => {
     handleFinalizedRef.current = handleFinalization;
   }, [handleFinalization]);
 
+  useEffect(() => {
+    adjustTimeRef.current = adjustTime;
+  }, [adjustTime]);
+
   // WebSocket connection management with fixed single-connection approach
   useEffect(() => {
     // If loading, don't start
@@ -573,6 +581,8 @@ const App: React.FC = () => {
       };
 
       ws.onmessage = (event) => {
+        // Capture timestamp as soon as we receive the message (not when it is verified)
+        const messageReceivedTime = adjustTimeRef.current(Date.now());
         const data = new Uint8Array(event.data);
         const kind = data[0];
         const payload = data.slice(1);
@@ -584,11 +594,11 @@ const App: React.FC = () => {
             break;
           case 1: // Notarization
             const notarized = parse_notarized(PUBLIC_KEY, payload);
-            if (notarized) handleNotarizedRef.current(notarized);
+            if (notarized) handleNotarizedRef.current(notarized, messageReceivedTime);
             break;
           case 2: // Finalization
             const finalized = parse_finalized(PUBLIC_KEY, payload);
-            if (finalized) handleFinalizedRef.current(finalized);
+            if (finalized) handleFinalizedRef.current(finalized, messageReceivedTime);
             break;
         }
       };

explorer/src/App.tsx

@@ -125,14 +125,43 @@ const StatsSection: React.FC<StatsSectionProps> = ({ views, connectionError = fa
         .sort((a, b) => a.block.height - b.block.height);
 
     const blockTimes: number[] = [];
+
+    // Group consecutive blocks to ensure we're only comparing truly adjacent blocks
+    const consecutiveGroups: typeof viewsWithBlocks[] = [];
+    let currentGroup: typeof viewsWithBlocks = [viewsWithBlocks[0]];
+
     for (let i = 1; i < viewsWithBlocks.length; i++) {
         const currentBlock = viewsWithBlocks[i].block;
-        const prevBlock = viewsWithBlocks[i - 1].block;
-        if (currentBlock && prevBlock &&
-            currentBlock.timestamp && prevBlock.timestamp &&
-            currentBlock.height === prevBlock.height + 1) {
-            const timeDiff = currentBlock.timestamp - prevBlock.timestamp;
-            if (timeDiff > 0 && timeDiff < 10000) { // Filter out unreasonable values (>10s)
+        const prevBlock = currentGroup[currentGroup.length - 1].block;
+
+        // If this block is consecutive to the last one in current group, add it
+        if (currentBlock.height === prevBlock.height + 1) {
+            currentGroup.push(viewsWithBlocks[i]);
+        } else {
+            // Start a new group if we have a gap
+            if (currentGroup.length >= 2) {
+                consecutiveGroups.push(currentGroup);
+            }
+            currentGroup = [viewsWithBlocks[i]];
+        }
+    }
+
+    // Don't forget the last group
+    if (currentGroup.length >= 2) {
+        consecutiveGroups.push(currentGroup);
+    }
+
+    // Calculate block times only within consecutive groups
+    for (const group of consecutiveGroups) {
+        // Only process groups with at least 3 blocks for more reliable measurements
+        if (group.length >= 3) {
+            for (let i = 1; i < group.length; i++) {
+                const currentBlock = group[i].block;
+                const prevBlock = group[i - 1].block;
+
+                // Use raw block timestamps directly - DO NOT apply clock skew correction
+                // Block timestamps come from the network itself, not browser time
+                const timeDiff = currentBlock.timestamp - prevBlock.timestamp;
                 blockTimes.push(timeDiff);
             }
         }

explorer/src/StatsSection.tsx

@@ -9,6 +9,9 @@ const timeout = 3000;
 // Interval to fetch server time (in milliseconds)
 const interval = 30000;
 
+// Uncertainty bound for clock skew (in milliseconds)
+const uncertaintyBound = 35;
+
 /**
  * Custom hook to detect clock skew between client and server
  * Runs once on mount and then every 30 seconds, using the latest successful measurement as the skew
@@ -68,10 +71,14 @@ export const useClockSkew = () => {
                 // Calculate skew
                 const adjustedLocalTime = localStartTime + networkLatency;
                 const skew = adjustedLocalTime - serverTime;
-                console.log('Local clock skew:', skew);
+
+                // If the clockSkew has an absolute value less than 35ms, make no adjustment
+                // This is within the range of uncertainty on measurement
+                const adjustedSkew = Math.abs(skew) < uncertaintyBound ? 0 : skew;
+                console.log(`Measured clock skew: ${skew}ms (Applied clock skew: ${adjustedSkew}ms)`);
 
                 // Update state with the new skew
-                setClockSkew(skew);
+                setClockSkew(adjustedSkew);
             } catch (err) {
                 console.error('Failed to fetch skew:', err);
                 // Keep the previous skew if the request fails

explorer/src/alto_types/alto_types_bg.wasm

@@ -1,6 +1,6 @@
 [package]
 name = "alto-inspector"
-version = "0.0.10"
+version = "0.0.11"
 publish = true
 edition = "2021"
 license = "MIT OR Apache-2.0"