Test v2026.5.0#191
Draft
patrick-ogrady wants to merge 11 commits into
Draft
Conversation
Deploying alto with
|
| Latest commit: |
2b0e9e4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://05db83bc.alto-8k4.pages.dev |
| Branch Preview URL: | https://v2026-5-0-testing.alto-8k4.pages.dev |
patrick-ogrady
commented
May 22, 2026
| if let Some(backfiller) = self.backfiller.clone() { | ||
| self.context | ||
| .child("backfill_record") | ||
| .spawn(move |_| async move { |
Contributor
Author
There was a problem hiding this comment.
let's add attributes?
patrick-ogrady
commented
May 22, 2026
patrick-ogrady
commented
May 22, 2026
| let marshal_handle = self.marshal.start(mailbox, self.buffer_mailbox, marshal); | ||
| let marshal_handle = self.marshal.start( | ||
| mailbox, | ||
| None::<buffered::Mailbox<PublicKey, Block>>, |
Contributor
Author
There was a problem hiding this comment.
Marshal should define some trait for this so we don't have to link Mailbox?
Contributor
Author
There was a problem hiding this comment.
We may just be able to implement some buffered trait over None (does nothing) and remove OptionalBuffer.
patrick-ogrady
commented
May 23, 2026
| use commonware_utils::NZUsize; | ||
| use std::time::Duration; | ||
|
|
||
| /// Verifies that marshal's Deliver handler rejects a finalization whose |
Contributor
Author
There was a problem hiding this comment.
restore this?
patrick-ogrady
commented
May 23, 2026
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { |
Contributor
Author
There was a problem hiding this comment.
restore tests?
patrick-ogrady
commented
May 23, 2026
| #[derive(Clone)] | ||
| pub struct MockSource { | ||
| pub block_handler: BlockHandler, | ||
| #[allow(dead_code)] |
patrick-ogrady
commented
May 23, 2026
| .worker_threads | ||
| .checked_add(config.signature_threads) | ||
| .expect("network buffer pool parallelism overflowed"); | ||
| // Storage I/O runs on Tokio's blocking pool. Include those threads in the |
Contributor
Author
There was a problem hiding this comment.
add \n before?
patrick-ogrady
commented
May 23, 2026
| .spawn(move |_| async move { | ||
| // Cache the finalized block in memory and enqueue its digest | ||
| // before acking so the consumer can recover it across restarts. | ||
| backfiller.record(&block).await; |
Contributor
Author
There was a problem hiding this comment.
should this/can this be a mailbox? I suppose record here is a durable write?
patrick-ogrady
commented
May 23, 2026
| spawn_cell!(self.context, self.run()) | ||
| } | ||
|
|
||
| async fn run(mut self) { |
Contributor
Author
There was a problem hiding this comment.
Should we just have this implement report for marshal?
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #191 +/- ##
==========================================
- Coverage 68.71% 68.68% -0.04%
==========================================
Files 30 30
Lines 5712 5815 +103
==========================================
+ Hits 3925 3994 +69
- Misses 1787 1821 +34
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: https://github.com/commonwarexyz/monorepo/milestone/18