[update] v0.0.45-50#96
Conversation
Deploying alto with
|
| Latest commit: |
5516283
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://28533c85.alto-8k4.pages.dev |
| Branch Preview URL: | https://v0-0-45.alto-8k4.pages.dev |
There was a problem hiding this comment.
Pull Request Overview
This PR updates various modules to integrate new library versions (v0.0.47) and API changes. Key changes include:
- Replacing calls to legacy deserialization with the new decode functions across modules.
- Renaming endpoint and function names (for example, notarization_get → notarized_get) to match updated APIs.
- Removing obsolete modules (archive and buffer) and updating internal messaging and proof verification logic.
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| inspector/src/utils.rs | Updated digest decoding and view extraction using new APIs. |
| inspector/src/main.rs | Adjusted identity decoding and renamed query functions. |
| client/src/lib.rs & client/src/consensus.rs | Updated error handling and API calls to use decode() consistently. |
| chain/src/lib.rs, chain/src/engine.rs, etc. | Upgraded internal modules with new parameters (e.g. deque_size) and updated test harness using Runner. |
| chain/src/actors/syncer/* | Removed legacy modules and adjusted message enum naming. |
| chain/src/actors/application/* | Removed unused proof verifier field and refactored message handling. |
| Cargo.toml workspaces | Updated dependency versions to v0.0.47 and removed unused deps. |
Comments suppressed due to low confidence (3)
chain/src/actors/syncer/archive.rs:1
- The archive module was completely removed. Please confirm that this removal is intended and that no other parts of the codebase depend on its functionality.
Entire file removal
chain/src/actors/syncer/buffer.rs:1
- The buffer module has been entirely removed. Verify that any references to this module are updated and that its removal will not break dependent functionality.
Entire file removal
chain/src/actors/application/actor.rs:55
- The prover field has been removed from the Actor struct. Please ensure that all essential proof verification logic is now correctly handled elsewhere.
pub struct Actor<R: Rng + Spawner + Metrics + Clock> { … }
| .expect("Failed to send finalization"); | ||
| } | ||
| _ => { | ||
| // Ignore other activity types |
There was a problem hiding this comment.
This is where we would track other activity types if we found them interesting.
|
Looks like there is a bug in the |
* make metrics port configurable * spike on peers vs hosts * validator compiles * progress * works * update instructions * add bootstrapper note * add note about ulimit * explaon bootstrappers * better logging for CLI * add more comments * nits
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #96 +/- ##
==========================================
- Coverage 57.64% 52.79% -4.86%
==========================================
Files 23 21 -2
Lines 3563 3349 -214
==========================================
- Hits 2054 1768 -286
- Misses 1509 1581 +72
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Related: commonwarexyz/monorepo#802
Related: commonwarexyz/monorepo#807
Related: commonwarexyz/monorepo#806
Resolves: #81
Resolves: #78
Resolves: #75
Resolves: #94
Resolves: #95
Resolves: #37
Future Work: #99
Future Work: #100
Future Work: #101
TODO
LoggerFunctionality monorepo#881indexbug: [storage/index] Panic onNonemonorepo#886TwoCap