Skip to content

[update] v0.0.45-50#96

Merged
patrick-ogrady merged 66 commits into
mainfrom
v0.0.45
May 3, 2025
Merged

[update] v0.0.45-50#96
patrick-ogrady merged 66 commits into
mainfrom
v0.0.45

Conversation

@patrick-ogrady
Copy link
Copy Markdown
Contributor

@patrick-ogrady patrick-ogrady commented Apr 22, 2025

Related: commonwarexyz/monorepo#802
Related: commonwarexyz/monorepo#807
Related: commonwarexyz/monorepo#806

Resolves: #81
Resolves: #78
Resolves: #75
Resolves: #94
Resolves: #95
Resolves: #37

Future Work: #99
Future Work: #100
Future Work: #101

TODO

@patrick-ogrady patrick-ogrady marked this pull request as draft April 22, 2025 21:45
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 22, 2025

Deploying alto with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5516283
Status: ✅  Deploy successful!
Preview URL: https://28533c85.alto-8k4.pages.dev
Branch Preview URL: https://v0-0-45.alto-8k4.pages.dev

View logs

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates various modules to integrate new library versions (v0.0.47) and API changes. Key changes include:

  • Replacing calls to legacy deserialization with the new decode functions across modules.
  • Renaming endpoint and function names (for example, notarization_get → notarized_get) to match updated APIs.
  • Removing obsolete modules (archive and buffer) and updating internal messaging and proof verification logic.

Reviewed Changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.

Show a summary per file
File Description
inspector/src/utils.rs Updated digest decoding and view extraction using new APIs.
inspector/src/main.rs Adjusted identity decoding and renamed query functions.
client/src/lib.rs & client/src/consensus.rs Updated error handling and API calls to use decode() consistently.
chain/src/lib.rs, chain/src/engine.rs, etc. Upgraded internal modules with new parameters (e.g. deque_size) and updated test harness using Runner.
chain/src/actors/syncer/* Removed legacy modules and adjusted message enum naming.
chain/src/actors/application/* Removed unused proof verifier field and refactored message handling.
Cargo.toml workspaces Updated dependency versions to v0.0.47 and removed unused deps.
Comments suppressed due to low confidence (3)

chain/src/actors/syncer/archive.rs:1

  • The archive module was completely removed. Please confirm that this removal is intended and that no other parts of the codebase depend on its functionality.
Entire file removal

chain/src/actors/syncer/buffer.rs:1

  • The buffer module has been entirely removed. Verify that any references to this module are updated and that its removal will not break dependent functionality.
Entire file removal

chain/src/actors/application/actor.rs:55

  • The prover field has been removed from the Actor struct. Please ensure that all essential proof verification logic is now correctly handled elsewhere.
pub struct Actor<R: Rng + Spawner + Metrics + Clock> { … }

.expect("Failed to send finalization");
}
_ => {
// Ignore other activity types
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where we would track other activity types if we found them interesting.

@patrick-ogrady
Copy link
Copy Markdown
Contributor Author

Looks like there is a bug in the index changes we made:

Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x0000c0c94e3f5bb0 in core::ptr::drop_in_place<alloc::boxed::Box<commonware_storage::index::storage::Record<u64>>> ()
[Current thread is 1 (Thread 0xfd436476ee40 (LWP 4177))]

* make metrics port configurable

* spike on peers vs hosts

* validator compiles

* progress

* works

* update instructions

* add bootstrapper note

* add note about ulimit

* explaon bootstrappers

* better logging for CLI

* add more comments

* nits
@patrick-ogrady patrick-ogrady changed the title [update] v0.0.45-47 [update] v0.0.45-49 May 2, 2025
@patrick-ogrady patrick-ogrady changed the title [update] v0.0.45-49 [update] v0.0.45-50 May 3, 2025
@patrick-ogrady patrick-ogrady merged commit 96b87a3 into main May 3, 2025
6 checks passed
@patrick-ogrady patrick-ogrady deleted the v0.0.45 branch May 3, 2025 03:53
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 49.05838% with 541 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.79%. Comparing base (96a2fae) to head (5516283).
⚠️ Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
chain/src/bin/setup.rs 0.00% 225 Missing ⚠️
chain/src/bin/validator.rs 0.00% 115 Missing ⚠️
client/src/consensus.rs 0.00% 76 Missing ⚠️
types/src/wasm.rs 0.00% 63 Missing ⚠️
chain/src/actors/syncer/actor.rs 90.59% 19 Missing ⚠️
types/src/lib.rs 86.07% 11 Missing ⚠️
types/src/block.rs 86.20% 8 Missing ⚠️
chain/src/actors/syncer/key.rs 61.11% 7 Missing ⚠️
chain/src/lib.rs 94.89% 7 Missing ⚠️
inspector/src/main.rs 0.00% 6 Missing ⚠️
... and 1 more
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   57.64%   52.79%   -4.86%     
==========================================
  Files          23       21       -2     
  Lines        3563     3349     -214     
==========================================
- Hits         2054     1768     -286     
- Misses       1509     1581      +72     
Files with missing lines Coverage Δ
chain/src/actors/application/actor.rs 90.47% <ø> (-0.56%) ⬇️
chain/src/actors/application/ingress.rs 100.00% <ø> (ø)
chain/src/actors/application/supervisor.rs 94.59% <100.00%> (-0.53%) ⬇️
chain/src/actors/syncer/ingress.rs 100.00% <100.00%> (ø)
chain/src/engine.rs 97.97% <100.00%> (+1.04%) ⬆️
client/src/lib.rs 0.00% <ø> (ø)
types/src/consensus.rs 100.00% <100.00%> (+10.10%) ⬆️
inspector/src/utils.rs 0.00% <0.00%> (ø)
inspector/src/main.rs 0.00% <0.00%> (ø)
chain/src/actors/syncer/key.rs 76.78% <61.11%> (+16.78%) ⬆️
... and 8 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96a2fae...5516283. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants