nits

Author: patrick-ogrady

consensus/src/marshal/mocks/harness.rs

@@ -994,12 +994,11 @@ pub fn certify_at_later_view_survives_earlier_view_pruning<H: TestHarness>() {
         );
         let orphan_digest = H::digest(&orphan);
 
-        // Verify `repeated` at V=1, then certify at V=100 (reproposal-style gap).
-        // Chain views below are disjoint from V=1 and V=100 so the verified cache
-        // at those views is not overwritten by chain proposals (verified_blocks
-        // drops subsequent writes at an existing view index).
+        // Verify `repeated` at V=1, then certify at V=25 (reproposal-style gap).
+        // The chain below starts at V=2 to avoid overwriting V=1 in the
+        // verified archive (which drops subsequent writes at an existing view).
         let v_early = Round::new(Epoch::zero(), View::new(1));
-        let v_late = Round::new(Epoch::zero(), View::new(100));
+        let v_late = Round::new(Epoch::zero(), View::new(25));
         let mut peers: [ValidatorHandle<H>; 0] = [];
         H::verify(&mut handle, v_early, &repeated, &mut peers).await;
         assert!(
@@ -1011,12 +1010,11 @@ pub fn certify_at_later_view_survives_earlier_view_pruning<H: TestHarness>() {
         H::verify(&mut handle, v_early, &orphan, &mut peers).await;
 
         // Drive the finalized chain forward to advance `last_processed_round`
-        // past V=1's retention boundary but not past V=100's. With
+        // past V=1's retention boundary but not past V=25's. With
         // view_retention_timeout=10 and prunable_items_per_section=10,
-        // processing views 50..=70 leaves `oldest_allowed=60` in both prunable
-        // archives. V=1 is dropped, V=100 is retained.
+        // processing views 2..=22 leaves `oldest_allowed=12` in both prunable
+        // archives. V=1 is dropped, V=25 is retained.
         const CHAIN_LEN: u64 = 21;
-        const CHAIN_START_VIEW: u64 = 50;
         let mut parent = Sha256::hash(b"");
         let mut parent_commitment = H::genesis_parent_commitment(NUM_VALIDATORS as u16);
         for i in 1..=CHAIN_LEN {
@@ -1029,17 +1027,11 @@ pub fn certify_at_later_view_survives_earlier_view_pruning<H: TestHarness>() {
             );
             let digest = H::digest(&block);
             let commitment = H::commitment(&block);
-            let view = View::new(CHAIN_START_VIEW + i - 1);
-            let round = Round::new(Epoch::zero(), view);
+            let round = Round::new(Epoch::zero(), View::new(i + 1));
             H::propose(&mut handle, round, &block).await;
-            let parent_view = if i == 1 {
-                View::zero()
-            } else {
-                View::new(CHAIN_START_VIEW + i - 2)
-            };
             let proposal = Proposal {
                 round,
-                parent: parent_view,
+                parent: View::new(i),
                 payload: commitment,
             };
             let finalization = H::make_finalization(proposal, &schemes, QUORUM);