outcome

Author: patrick-ogrady

actor/src/lib.rs

@@ -31,16 +31,16 @@ commonware_macros::stability_scope!(BETA {
     /// Feedback from endpoints that may reject work under backpressure.
     #[derive(Clone, Copy, Debug, PartialEq, Eq)]
     pub enum Unreliable<T> {
-        /// Normal endpoint feedback from the submission attempt.
-        Feedback(T),
+        /// Endpoint outcome from the submission attempt.
+        Outcome(T),
         /// The work was rejected by the endpoint.
         Rejected,
     }
 
     impl Unreliable<Feedback> {
         /// Wrap endpoint feedback for an endpoint that may reject work.
         pub const fn new(feedback: Feedback) -> Self {
-            Self::Feedback(feedback)
+            Self::Outcome(feedback)
         }
 
         /// Create rejected feedback.
@@ -51,7 +51,7 @@ commonware_macros::stability_scope!(BETA {
         /// Returns `true` when the endpoint handled the submission.
         pub const fn accepted(self) -> bool {
             match self {
-                Self::Feedback(feedback) => feedback.accepted(),
+                Self::Outcome(feedback) => feedback.accepted(),
                 Self::Rejected => false,
             }
         }

p2p/src/authenticated/discovery/actors/router/ingress.rs

@@ -93,7 +93,7 @@ impl<P: PublicKey> Mailbox<P> {
     /// which is harmless since the router no longer tracks any peers.
     pub fn release(&self, peer: P) -> Feedback {
         match self.0.enqueue(Message::Release { peer }) {
-            Unreliable::Feedback(feedback) => feedback,
+            Unreliable::Outcome(feedback) => feedback,
             Unreliable::Rejected => unreachable!("router release cannot be rejected"),
         }
     }

p2p/src/authenticated/lookup/actors/router/ingress.rs

@@ -93,7 +93,7 @@ impl<P: PublicKey> Mailbox<P> {
     /// which is harmless since the router no longer tracks any peers.
     pub fn release(&self, peer: P) -> Feedback {
         match self.0.enqueue(Message::Release { peer }) {
-            Unreliable::Feedback(feedback) => feedback,
+            Unreliable::Outcome(feedback) => feedback,
             Unreliable::Rejected => unreachable!("router release cannot be rejected"),
         }
     }

resolver/src/p2p/fetcher.rs

@@ -292,7 +292,7 @@ where
                     payload: wire::Payload::Request(key.clone()),
                 };
                 match checked.send(message, self.priority_requests) {
-                    Unreliable::Feedback(Feedback::Ok | Feedback::Backoff) => {
+                    Unreliable::Outcome(Feedback::Ok | Feedback::Backoff) => {
                         // Success - move from pending to active
                         self.requests_sent.inc(Status::Success);
                         self.pending.remove(&key);
@@ -310,7 +310,7 @@ where
                         self.key_to_id.insert(key, id);
                         return;
                     }
-                    feedback @ (Unreliable::Rejected | Unreliable::Feedback(Feedback::Closed)) => {
+                    feedback @ (Unreliable::Rejected | Unreliable::Outcome(Feedback::Closed)) => {
                         // Send was not handled, try next peer
                         self.requests_sent.inc(Status::Dropped);
                         debug!(?peer, ?feedback, "send failed");