nits

Author: patrick-ogrady

actor/src/lib.rs

@@ -31,7 +31,7 @@ commonware_macros::stability_scope!(BETA {
     /// Feedback from endpoints that may reject work under backpressure.
     #[derive(Clone, Copy, Debug, PartialEq, Eq)]
     pub enum Unreliable<T> {
-        /// Feedback returned by the endpoint.
+        /// Normal endpoint feedback from the submission attempt.
         Feedback(T),
         /// The work was rejected by the endpoint.
         Rejected,
@@ -57,11 +57,5 @@ commonware_macros::stability_scope!(BETA {
         }
     }
 
-    impl From<Feedback> for Unreliable<Feedback> {
-        fn from(feedback: Feedback) -> Self {
-            Self::new(feedback)
-        }
-    }
-
     pub mod mailbox;
 });

actor/src/mailbox.rs

@@ -122,9 +122,10 @@ pub trait UnreliablePolicy: Sized {
     /// the message, coalescing it with retained work, replacing older retained work, or deliberately
     /// doing no work because the message is already satisfied, superseded, or no longer needed.
     ///
-    /// Returns `false` only when the policy rejects the message under backpressure. This is the
-    /// unreliable case: the submitted work was not semantically handled, and callers that care
-    /// should retry or treat the submission as failed.
+    /// Returns `false` only when the policy rejects the message under backpressure without
+    /// retaining, coalescing, replacing, or otherwise handling it. This is the unreliable case: the
+    /// submitted work was not semantically handled, and callers that care should retry or treat the
+    /// submission as failed.
     ///
     /// # Warning
     ///

p2p/src/authenticated/discovery/actors/spawner/ingress.rs

@@ -32,8 +32,8 @@ impl<P: PublicKey, O: Sink, I: Stream> UnreliablePolicy for Message<O, I, P> {
 impl<P: PublicKey, O: Sink, I: Stream> Mailbox<Message<O, I, P>> {
     /// Send a message to the actor to spawn a new task for the given peer.
     ///
-    /// This may reject when the spawner is backlogged or closed, which is harmless since stale
-    /// connections do not need to be spawned.
+    /// This may be rejected when the spawner is backlogged, or return closed after shutdown, which
+    /// is harmless since stale connections do not need to be spawned.
     pub fn spawn(
         &mut self,
         connection: (Sender<O>, Receiver<I>),

p2p/src/authenticated/lookup/actors/spawner/ingress.rs

@@ -32,8 +32,8 @@ impl<Si: Sink, St: Stream, P: PublicKey> UnreliablePolicy for Message<Si, St, P>
 impl<Si: Sink, St: Stream, P: PublicKey> Mailbox<Message<Si, St, P>> {
     /// Send a message to the actor to spawn a new task for the given peer.
     ///
-    /// This may reject when the spawner is backlogged or closed, which is harmless since stale
-    /// connections do not need to be spawned.
+    /// This may be rejected when the spawner is backlogged, or return closed after shutdown, which
+    /// is harmless since stale connections do not need to be spawned.
     pub fn spawn(
         &mut self,
         connection: (Sender<Si>, Receiver<St>),