PR feedback

Author: michaelkaplan13

utils/src/bitmap/roaring/container/bitmap.rs

@@ -49,11 +49,17 @@ impl Default for Bitmap {
 
 impl From<&array::Array> for Bitmap {
     fn from(array: &array::Array) -> Self {
-        let mut container = Self::new();
+        let mut words = [0u64; WORDS];
         for value in array.iter() {
-            container.insert(value);
+            let word_idx = (value >> 6) as usize;
+            let bit_idx = value & 63;
+            words[word_idx] |= 1u64 << bit_idx;
+        }
+        Self {
+            words,
+            cardinality: array.len() as u32,
+            run_count: count_runs(&words),
         }
-        container
     }
 }
 

utils/src/bitmap/roaring/container/mod.rs

@@ -35,7 +35,7 @@ pub mod bitmap;
 pub mod run;
 
 #[cfg(not(feature = "std"))]
-use alloc::boxed::Box;
+use alloc::{boxed::Box, vec::Vec};
 pub use array::Array;
 pub use bitmap::Bitmap;
 use bytes::{Buf, BufMut};