Skip to content

[consensus/simplex] Cleanup Batcher Update Messaging #2381

@patrick-ogrady

Description

@patrick-ogrady

To simplify voter, we should send batcher view updates whenever we call enter_view rather than again at the end of the message loop.

This would prevent the "edge case" where we drop votes here (although wouldn't address the "not helping with finalizations when we otherwise would have"):

// Attempt to send any new view messages
//
// The batcher may drop votes we construct here if it has not yet been updated to the
// message's view. This only happens when we skip ahead multiple views, which always
// coincides with entering a new view (triggering a batcher update below before we send
// any votes for the new current view). This has no impact on liveness, however, we may miss
// building a finalization for an old view where we otherwise could have contributed.

Related: #2351

Metadata

Metadata

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

Status

Staged

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions