Skip to content

[consensus/marshal] Add restart benchmarks#3558

Open
viktorcrypt wants to merge 2 commits into
commonwarexyz:mainfrom
viktorcrypt:marshal-restart-benchmark
Open

[consensus/marshal] Add restart benchmarks#3558
viktorcrypt wants to merge 2 commits into
commonwarexyz:mainfrom
viktorcrypt:marshal-restart-benchmark

Conversation

@viktorcrypt
Copy link
Copy Markdown

Summary

  • add a marshal benchmark target for restart recovery
  • benchmark both standard and coding marshal variants
  • seed finalized blocks, finalizations, and application metadata directly in storage
  • measure archive reopen plus Actor::init recovery time

Detail

This adds focused restart benchmarks for marshal recovery.

Each benchmark prepopulates persisted marshal state, then repeatedly reopens the finalized archives and initializes the marshal actor again. This measures the restore path directly instead of bringing up the full network or application stack.

Both standard and coding variants are covered so restart regressions in either recovery path become visible in benchmarks.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6c1359b. Configure here.

Comment thread consensus/src/marshal/benches/restart.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant