Skip to content

[consensus] Final Certify Nits#3629

Merged
patrick-ogrady merged 7 commits into
cl/rm-double-certifyfrom
final-final-certify-nits
Apr 20, 2026
Merged

[consensus] Final Certify Nits#3629
patrick-ogrady merged 7 commits into
cl/rm-double-certifyfrom
final-final-certify-nits

Conversation

@patrick-ogrady
Copy link
Copy Markdown
Contributor

Related: #3543

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 20, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
commonware-mcp 82c015e Apr 20 2026, 06:19 AM

@patrick-ogrady patrick-ogrady changed the base branch from main to cl/rm-double-certify April 20, 2026 06:00
Comment thread consensus/src/marshal/core/actor.rs Outdated
Comment thread consensus/src/marshal/core/actor.rs Outdated
Comment thread consensus/src/marshal/core/variant.rs Outdated
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 20, 2026

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 82c015e
Status: ✅  Deploy successful!
Preview URL: https://409276ae.monorepo-eu0.pages.dev
Branch Preview URL: https://final-final-certify-nits.monorepo-eu0.pages.dev

View logs

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3630920. Configure here.

Comment thread consensus/src/marshal/core/actor.rs Outdated
@patrick-ogrady patrick-ogrady merged commit eca4cdc into cl/rm-double-certify Apr 20, 2026
168 checks passed
@patrick-ogrady patrick-ogrady deleted the final-final-certify-nits branch April 20, 2026 06:20
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (cl/rm-double-certify@28ee529). Learn more about missing BASE report.

@@                   Coverage Diff                   @@
##             cl/rm-double-certify    #3629   +/-   ##
=======================================================
  Coverage                        ?   95.84%           
=======================================================
  Files                           ?      440           
  Lines                           ?   171195           
  Branches                        ?     3978           
=======================================================
  Hits                            ?   164076           
  Misses                          ?     5853           
  Partials                        ?     1266           
Files with missing lines Coverage Δ
consensus/src/lib.rs 0.00% <ø> (ø)
consensus/src/marshal/core/actor.rs 92.24% <ø> (ø)
consensus/src/marshal/mocks/harness.rs 98.63% <ø> (ø)
consensus/src/marshal/standard/inline.rs 86.12% <ø> (ø)
storage/src/archive/mod.rs 88.61% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28ee529...82c015e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant