Skip to content

[consensus] Decouple Propose Durability from Broadcast#3630

Merged
patrick-ogrady merged 11 commits into
cl/rm-double-certifyfrom
decompose-propose
Apr 20, 2026
Merged

[consensus] Decouple Propose Durability from Broadcast#3630
patrick-ogrady merged 11 commits into
cl/rm-double-certifyfrom
decompose-propose

Conversation

@patrick-ogrady
Copy link
Copy Markdown
Contributor

Related: #3543

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 20, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
commonware-mcp 1cef660 Apr 20 2026, 09:05 AM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 20, 2026

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1cef660
Status: ✅  Deploy successful!
Preview URL: https://bd2a7196.monorepo-eu0.pages.dev
Branch Preview URL: https://decompose-propose.monorepo-eu0.pages.dev

View logs

@patrick-ogrady patrick-ogrady changed the title spike [consensus] Decouple Propose Durability from Broadcast Apr 20, 2026
Comment thread consensus/src/marshal/coding/marshaled.rs
Comment thread consensus/src/marshal/standard/deferred.rs Outdated
Comment thread consensus/src/simplex/actors/voter/actor.rs Outdated
Comment thread consensus/src/lib.rs Outdated
Comment thread consensus/src/simplex/mod.rs Outdated
@patrick-ogrady patrick-ogrady merged commit 826c503 into cl/rm-double-certify Apr 20, 2026
168 checks passed
@patrick-ogrady patrick-ogrady deleted the decompose-propose branch April 20, 2026 09:13
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

❌ Patch coverage is 76.64234% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.86%. Comparing base (d2b918e) to head (1cef660).
⚠️ Report is 1 commits behind head on cl/rm-double-certify.

Files with missing lines Patch % Lines
consensus/src/marshal/coding/marshaled.rs 0.00% 11 Missing and 1 partial ⚠️
consensus/src/marshal/standard/inline.rs 35.29% 10 Missing and 1 partial ⚠️
consensus/src/marshal/standard/deferred.rs 63.15% 5 Missing and 2 partials ⚠️
consensus/src/marshal/core/actor.rs 66.66% 0 Missing and 1 partial ⚠️
consensus/src/simplex/actors/batcher/mod.rs 83.33% 0 Missing and 1 partial ⚠️
@@                   Coverage Diff                    @@
##           cl/rm-double-certify    #3630      +/-   ##
========================================================
+ Coverage                 95.85%   95.86%   +0.01%     
========================================================
  Files                       440      440              
  Lines                    171667   171029     -638     
  Branches                   3997     3976      -21     
========================================================
- Hits                     164544   163956     -588     
+ Misses                     5850     5807      -43     
+ Partials                   1273     1266       -7     
Files with missing lines Coverage Δ
consensus/src/lib.rs 0.00% <ø> (ø)
consensus/src/marshal/application/validation.rs 100.00% <ø> (ø)
consensus/src/marshal/coding/mod.rs 98.43% <100.00%> (-0.03%) ⬇️
consensus/src/marshal/coding/variant.rs 92.30% <ø> (-7.70%) ⬇️
consensus/src/marshal/core/mailbox.rs 100.00% <100.00%> (ø)
consensus/src/marshal/mocks/harness.rs 98.63% <100.00%> (ø)
consensus/src/marshal/standard/mod.rs 97.13% <100.00%> (+1.33%) ⬆️
consensus/src/ordered_broadcast/mocks/automaton.rs 94.11% <100.00%> (-0.17%) ⬇️
consensus/src/simplex/actors/batcher/actor.rs 93.58% <100.00%> (-0.26%) ⬇️
consensus/src/simplex/actors/voter/actor.rs 97.19% <100.00%> (+0.01%) ⬆️
... and 8 more

... and 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2b918e...1cef660. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant