Skip to content

[consensus] Address Last Round of Feedback#3634

Merged
patrick-ogrady merged 10 commits into
cl/rm-double-certifyfrom
address-follow-up-findings
Apr 20, 2026
Merged

[consensus] Address Last Round of Feedback#3634
patrick-ogrady merged 10 commits into
cl/rm-double-certifyfrom
address-follow-up-findings

Conversation

@patrick-ogrady
Copy link
Copy Markdown
Contributor

Related: #3543

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 20, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
commonware-mcp 9d01ab5 Apr 20 2026, 07:17 PM

Comment thread consensus/src/marshal/mocks/harness.rs Outdated
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 20, 2026

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9d01ab5
Status: ✅  Deploy successful!
Preview URL: https://a2659a97.monorepo-eu0.pages.dev
Branch Preview URL: https://address-follow-up-findings.monorepo-eu0.pages.dev

View logs

Comment thread consensus/src/simplex/actors/voter/actor.rs Outdated
@patrick-ogrady patrick-ogrady marked this pull request as ready for review April 20, 2026 19:17
@patrick-ogrady patrick-ogrady merged commit a5db735 into cl/rm-double-certify Apr 20, 2026
168 checks passed
@patrick-ogrady patrick-ogrady deleted the address-follow-up-findings branch April 20, 2026 19:27
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

❌ Patch coverage is 99.16435% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.87%. Comparing base (826c503) to head (9d01ab5).
⚠️ Report is 1 commits behind head on cl/rm-double-certify.

Files with missing lines Patch % Lines
consensus/src/marshal/mocks/harness.rs 98.73% 3 Missing ⚠️
@@                  Coverage Diff                  @@
##           cl/rm-double-certify    #3634   +/-   ##
=====================================================
  Coverage                 95.86%   95.87%           
=====================================================
  Files                       440      440           
  Lines                    171304   171285   -19     
  Branches                   3989     3980    -9     
=====================================================
- Hits                     164221   164211   -10     
+ Misses                     5814     5810    -4     
+ Partials                   1269     1264    -5     
Files with missing lines Coverage Δ
consensus/src/marshal/coding/marshaled.rs 80.58% <100.00%> (+0.21%) ⬆️
consensus/src/marshal/coding/mod.rs 98.51% <100.00%> (+0.07%) ⬆️
consensus/src/marshal/standard/deferred.rs 92.50% <100.00%> (+0.63%) ⬆️
consensus/src/marshal/standard/inline.rs 88.39% <100.00%> (-0.04%) ⬇️
consensus/src/marshal/standard/mod.rs 97.13% <ø> (ø)
consensus/src/simplex/actors/voter/actor.rs 97.19% <ø> (ø)
consensus/src/marshal/mocks/harness.rs 98.72% <98.73%> (+0.08%) ⬆️

... and 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 826c503...9d01ab5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant