[consensus/marshal] `commonware-glue` marshal changes by clabby · Pull Request #3764 · commonwarexyz/monorepo

clabby · 2026-05-12T16:10:40Z

Overview

Ports the changes to marshal from #3381:

Add a GetProcessedHeight function to marshal's mailbox, so that the startup routine can query marshal's processed height to determine if it needs to roll back one or more databases.

cloudflare-workers-and-pages · 2026-05-12T16:10:50Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Updated (UTC)
✅ Deployment successful! View logs	commonware-mcp	`d99635d`	May 22 2026, 07:48 PM

cloudflare-workers-and-pages · 2026-05-12T16:10:55Z

Deploying monorepo with Cloudflare Pages

Latest commit:	`d99635d`
Status:	✅ Deploy successful!
Preview URL:	https://12cfe1dc.monorepo-eu0.pages.dev
Branch Preview URL:	https://cl-glue-marshal-changes.monorepo-eu0.pages.dev

View logs

github-actions · 2026-05-12T16:15:37Z

Benchmark results

Tip

✅ PASSED: No benchmark exceeded the regression threshold.

Benchmark comparison table

Benchmark	Baseline (main)	Current	Delta	Threshold	Status
`qmdb::merkleize/variant=any::unordered::fixed::mmr keys=10000 ch=false sync=false`	1.577 ms	1.604 ms	+1.71%	10.00%	✅ PASS
`qmdb::merkleize/variant=current::ordered::fixed::mmb chunk=256 keys=10000 ch=true sync=false`	3.085 ms	3.112 ms	+0.85%	10.00%	✅ PASS

Baseline commit(s): 527763b5f80a

BrendanChou · 2026-05-13T20:38:12Z

+                            },
+                            Recipients::One(peer) => {
+                                let peers = NonEmptyVec::new(peer);
+                                resolver.fetch_targeted(request, peers).await;


Should we also change the API of resolver to use Recipients? I guess not (?)

My thinking was no, since it's generic over the transport?

patrick-ogrady · 2026-05-14T06:09:09Z

-                        // Skip if height is at or below the floor
-                        if height <= self.last_processed_height {
+                        // Skip if height is below the floor
+                        if height < self.last_processed_height {


What is the rationale behind this change? if we've processed a block, we must have a finalization at or above this?

When we kick off state sync, we set the floor far in the future. That block has not necessarily been processed yet. We need to allow for marshal to fetch the floor, in the case that it is missing.

Got it. That becomes very similar to something I was considering for my state sync cleanup.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit d13f1c6. Configure here.}

codecov · 2026-05-22T20:44:44Z

Codecov Report

❌ Patch coverage is 55.17241% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.76%. Comparing base (edc5cce) to head (d99635d).
⚠️ Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
consensus/src/marshal/core/mailbox.rs	16.66%	10 Missing ⚠️
consensus/src/marshal/core/actor.rs	0.00%	3 Missing ⚠️

@@            Coverage Diff             @@
##             main    #3764      +/-   ##
==========================================
- Coverage   95.77%   95.76%   -0.02%     
==========================================
  Files         486      486              
  Lines      200338   200706     +368     
  Branches     4858     4858              
==========================================
+ Hits       191872   192201     +329     
- Misses       6834     6873      +39     
  Partials     1632     1632

Files with missing lines	Coverage Δ
consensus/src/marshal/ancestry.rs	`93.54% <100.00%> (+0.52%)`	⬆️
consensus/src/marshal/core/actor.rs	`92.26% <0.00%> (-0.21%)`	⬇️
consensus/src/marshal/core/mailbox.rs	`91.77% <16.66%> (-0.96%)`	⬇️

... and 41 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc5cce...d99635d. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

clabby self-assigned this May 12, 2026

clabby added this to Tracker May 12, 2026

clabby force-pushed the cl/glue-marshal-changes branch from 6ed2e53 to f72fb17 Compare May 12, 2026 16:10

clabby requested review from andresilva and patrick-ogrady May 12, 2026 18:15

clabby commented May 13, 2026

View reviewed changes

Comment thread consensus/src/marshal/ancestry.rs Outdated

clabby force-pushed the cl/glue-marshal-changes branch from f72fb17 to 298de8d Compare May 13, 2026 18:30

BrendanChou previously approved these changes May 13, 2026

View reviewed changes

clabby dismissed BrendanChou’s stale review via 833f307 May 13, 2026 20:44

BrendanChou previously approved these changes May 13, 2026

View reviewed changes

clabby force-pushed the cl/glue-marshal-changes branch from 833f307 to eef3a95 Compare May 13, 2026 23:13

clabby enabled auto-merge May 13, 2026 23:13

patrick-ogrady reviewed May 14, 2026

View reviewed changes

clabby force-pushed the cl/glue-marshal-changes branch from eef3a95 to abb360e Compare May 14, 2026 14:34

clabby disabled auto-merge May 14, 2026 15:31

clabby added this pull request to the merge queue May 14, 2026

clabby removed this pull request from the merge queue due to a manual request May 14, 2026

clabby dismissed BrendanChou’s stale review via 468907b May 15, 2026 00:13

clabby force-pushed the cl/glue-marshal-changes branch from abb360e to 468907b Compare May 15, 2026 00:13

cursor Bot reviewed May 15, 2026

View reviewed changes

Comment thread consensus/src/marshal/core/actor.rs Outdated

clabby force-pushed the cl/glue-marshal-changes branch from 468907b to 69ee63f Compare May 15, 2026 18:05

cursor Bot reviewed May 15, 2026

View reviewed changes

Comment thread consensus/src/marshal/core/mailbox.rs

Comment thread consensus/src/marshal/core/mailbox.rs Outdated

clabby force-pushed the cl/glue-marshal-changes branch 2 times, most recently from c48fb77 to d13f1c6 Compare May 19, 2026 18:04

cursor Bot reviewed May 19, 2026

View reviewed changes

Comment thread consensus/src/marshal/core/actor.rs Outdated

clabby mentioned this pull request May 19, 2026

[consensus] Restore marshal ancestor stream symmetry #3835

Merged

clabby force-pushed the cl/glue-marshal-changes branch from d13f1c6 to 7d3329c Compare May 20, 2026 17:27

clabby force-pushed the cl/glue-marshal-changes branch 5 times, most recently from dd097ec to 0258591 Compare May 21, 2026 16:38

clabby mentioned this pull request May 21, 2026

[glue] Introduce commonware-glue #3381

Open

clabby force-pushed the cl/glue-marshal-changes branch from 0258591 to 7199ec6 Compare May 22, 2026 15:14

clabby moved this to Ready for Review in Tracker May 22, 2026

[consensus/marshal] commonware-glue marshal changes

bb6cdbb

clabby force-pushed the cl/glue-marshal-changes branch from 7199ec6 to bb6cdbb Compare May 22, 2026 15:46

patrick-ogrady added 2 commits May 22, 2026 12:39

nits

b8d93c4

nit

d99635d

patrick-ogrady approved these changes May 22, 2026

View reviewed changes

patrick-ogrady merged commit c1cd5a3 into main May 22, 2026
176 checks passed

patrick-ogrady deleted the cl/glue-marshal-changes branch May 22, 2026 19:56

github-project-automation Bot moved this from Ready for Review to Done in Tracker May 22, 2026

Conversation

clabby commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Uh oh!

cloudflare-workers-and-pages Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying with Cloudflare Workers

Uh oh!

cloudflare-workers-and-pages Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying monorepo with Cloudflare Pages

Uh oh!

github-actions Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmark results

Uh oh!

Uh oh!

Uh oh!

BrendanChou May 13, 2026

Choose a reason for hiding this comment

Uh oh!

clabby May 13, 2026

Choose a reason for hiding this comment

Uh oh!

patrick-ogrady May 14, 2026

Choose a reason for hiding this comment

Uh oh!

clabby May 14, 2026

Choose a reason for hiding this comment

Uh oh!

patrick-ogrady May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented May 22, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

clabby commented May 12, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented May 12, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented May 12, 2026 •

edited

Loading

github-actions Bot commented May 12, 2026 •

edited

Loading

patrick-ogrady May 14, 2026 •

edited

Loading