Skip to content

use checked math

fd84861
Select commit
Loading
Failed to load commit list.
Open

[storage/journal/contiguous] avoid need to fsync when crossing blob boundaries #3790

use checked math
fd84861
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 21, 2026 in 0s

95.78% (+0.01%) compared to edc5cce

View this Pull Request on Codecov

95.78% (+0.01%) compared to edc5cce

Details

Codecov Report

❌ Patch coverage is 96.53821% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.78%. Comparing base (edc5cce) to head (fd84861).

Files with missing lines Patch % Lines
storage/src/journal/contiguous/variable.rs 93.90% 26 Missing and 5 partials ⚠️
storage/src/journal/contiguous/fixed.rs 98.69% 9 Missing and 4 partials ⚠️
storage/src/journal/segmented/variable.rs 10.00% 8 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##             main    #3790      +/-   ##
==========================================
+ Coverage   95.77%   95.78%   +0.01%     
==========================================
  Files         486      486              
  Lines      200338   201613    +1275     
  Branches     4858     4879      +21     
==========================================
+ Hits       191872   193123    +1251     
- Misses       6834     6856      +22     
- Partials     1632     1634       +2     
Files with missing lines Coverage Δ
storage/src/journal/contiguous/metrics.rs 100.00% <100.00%> (ø)
storage/src/journal/contiguous/mod.rs 48.64% <ø> (ø)
storage/src/journal/segmented/fixed.rs 97.53% <100.00%> (+<0.01%) ⬆️
storage/src/qmdb/store/db.rs 91.01% <ø> (ø)
storage/src/qmdb/sync/engine.rs 91.78% <ø> (ø)
storage/src/queue/shared.rs 90.71% <ø> (ø)
storage/src/queue/storage.rs 99.06% <ø> (ø)
storage/src/journal/segmented/variable.rs 93.66% <10.00%> (-0.27%) ⬇️
storage/src/journal/contiguous/fixed.rs 98.21% <98.69%> (+1.11%) ⬆️
storage/src/journal/contiguous/variable.rs 97.88% <93.90%> (-0.91%) ⬇️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc5cce...fd84861. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.