Skip to content

[consensus/marshal] AncestorStream fetch duration histogram#3832

Merged
patrick-ogrady merged 6 commits into
mainfrom
cl/ancestry-fetch-histogram
May 22, 2026
Merged

[consensus/marshal] AncestorStream fetch duration histogram#3832
patrick-ogrady merged 6 commits into
mainfrom
cl/ancestry-fetch-histogram

Conversation

@clabby
Copy link
Copy Markdown
Collaborator

@clabby clabby commented May 19, 2026

Overview

Adds a histogram maintained by the Marshaled application wrapper that tracks the latency of a block fetched by the AncestorStream.

@clabby clabby self-assigned this May 19, 2026
@clabby clabby added this to Tracker May 19, 2026
@clabby clabby moved this to Ready for Review in Tracker May 19, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 19, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
commonware-mcp ea55b21 May 22 2026, 09:40 PM

@clabby clabby changed the title Cl/ancestry fetch histogram [consensus/marshal] AncestorStream fetch duration histogram May 19, 2026
Comment thread consensus/src/marshal/mocks/harness.rs Outdated
Comment thread consensus/src/marshal/mocks/harness.rs Outdated
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 19, 2026

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: ea55b21
Status:⚡️  Build in progress...

View logs

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

Benchmark results

Tip

PASSED: No benchmark exceeded the regression threshold.

Benchmark comparison table
Benchmark Baseline (main) Current Delta Threshold Status
qmdb::merkleize/variant=any::unordered::fixed::mmr keys=10000 ch=false sync=false 1.625 ms 1.575 ms -3.09% 10.00% ✅ PASS
qmdb::merkleize/variant=current::ordered::fixed::mmb chunk=256 keys=10000 ch=true sync=false 3.118 ms 3.018 ms -3.23% 10.00% ✅ PASS

Baseline commit(s): 979d2a2f657f

@clabby clabby force-pushed the cl/ancestry-fetch-histogram branch from 38c538f to 7cff5f5 Compare May 20, 2026 16:34
@patrick-ogrady patrick-ogrady added this to the v2026.5.0 milestone May 20, 2026
# Conflicts:
#	consensus/src/marshal/ancestry.rs
#	consensus/src/marshal/coding/marshaled.rs
#	consensus/src/marshal/core/mailbox.rs
#	consensus/src/marshal/standard/validation.rs
@patrick-ogrady patrick-ogrady merged commit 86f9be7 into main May 22, 2026
12 of 14 checks passed
@patrick-ogrady patrick-ogrady deleted the cl/ancestry-fetch-histogram branch May 22, 2026 21:40
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Tracker May 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

❌ Patch coverage is 99.50495% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.78%. Comparing base (2ac1695) to head (ea55b21).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
consensus/src/marshal/standard/inline.rs 90.90% 1 Missing ⚠️
@@           Coverage Diff           @@
##             main    #3832   +/-   ##
=======================================
  Coverage   95.77%   95.78%           
=======================================
  Files         486      486           
  Lines      201251   201349   +98     
  Branches     4876     4876           
=======================================
+ Hits       192754   192853   +99     
  Misses       6862     6862           
+ Partials     1635     1634    -1     
Files with missing lines Coverage Δ
consensus/src/marshal/ancestry.rs 95.20% <100.00%> (+1.65%) ⬆️
consensus/src/marshal/coding/marshaled.rs 83.66% <100.00%> (+0.44%) ⬆️
consensus/src/marshal/core/mailbox.rs 91.86% <100.00%> (+0.08%) ⬆️
consensus/src/marshal/mocks/harness.rs 98.78% <100.00%> (+<0.01%) ⬆️
consensus/src/marshal/standard/deferred.rs 94.49% <100.00%> (+0.07%) ⬆️
consensus/src/marshal/standard/validation.rs 81.92% <100.00%> (+0.44%) ⬆️
consensus/src/marshal/standard/inline.rs 90.58% <90.90%> (-0.01%) ⬇️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7e8f48...ea55b21. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants