Skip to content

[consensus] Restore marshal ancestor stream symmetry#3835

Merged
patrick-ogrady merged 7 commits into
mainfrom
cl/restore-marshal-symmetry
May 20, 2026
Merged

[consensus] Restore marshal ancestor stream symmetry#3835
patrick-ogrady merged 7 commits into
mainfrom
cl/restore-marshal-symmetry

Conversation

@clabby
Copy link
Copy Markdown
Collaborator

@clabby clabby commented May 19, 2026

Overview

Restores symmetry between the coding and standard marshal mailboxes, where the BlockProvider implementation was lost on the coding variant in 16e6e61.

Also requires Unpin on the Stream passed through the Application interface's functions, to remove the need for users to manually pin the stream.

Also requires 'static on the same Stream to allow for the ErasedBlockProvider in #3764

@clabby clabby requested a review from patrick-ogrady May 19, 2026 21:37
@clabby clabby self-assigned this May 19, 2026
@clabby clabby added this to Tracker May 19, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 19, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
commonware-mcp 49f4380 May 20 2026, 04:00 PM

@clabby clabby moved this to Ready for Review in Tracker May 19, 2026
@clabby clabby force-pushed the cl/restore-marshal-symmetry branch from cdf0a61 to 14574dc Compare May 19, 2026 21:38
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 19, 2026

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 49f4380
Status: ✅  Deploy successful!
Preview URL: https://920204cf.monorepo-eu0.pages.dev
Branch Preview URL: https://cl-restore-marshal-symmetry.monorepo-eu0.pages.dev

View logs

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

Benchmark results

Tip

PASSED: No benchmark exceeded the regression threshold.

Benchmark comparison table
Benchmark Baseline (main) Current Delta Threshold Status
qmdb::merkleize/variant=any::unordered::fixed::mmr keys=10000 ch=false sync=false 1.567 ms 1.717 ms +9.57% 10.00% ✅ PASS
qmdb::merkleize/variant=current::ordered::fixed::mmb chunk=256 keys=10000 ch=true sync=false 3.100 ms 3.128 ms +0.89% 10.00% ✅ PASS

Baseline commit(s): 14a016a55f43

Comment thread consensus/src/marshal/coding/mod.rs
@clabby clabby force-pushed the cl/restore-marshal-symmetry branch from 14574dc to e3e254a Compare May 19, 2026 22:56
Comment thread examples/reshare/src/application/core.rs
@clabby clabby force-pushed the cl/restore-marshal-symmetry branch from e3e254a to 4c470f7 Compare May 20, 2026 02:58
Comment thread consensus/src/marshal/coding/variant.rs Outdated
@clabby clabby force-pushed the cl/restore-marshal-symmetry branch from 265bd8a to a773938 Compare May 20, 2026 14:31
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a773938. Configure here.

Comment thread consensus/src/marshal/standard/variant.rs
@clabby clabby force-pushed the cl/restore-marshal-symmetry branch from a773938 to c06078b Compare May 20, 2026 14:36
Comment thread consensus/src/marshal/ancestry.rs Outdated
@patrick-ogrady patrick-ogrady merged commit 25bd841 into main May 20, 2026
178 checks passed
@patrick-ogrady patrick-ogrady deleted the cl/restore-marshal-symmetry branch May 20, 2026 16:47
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Tracker May 20, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 98.23009% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.74%. Comparing base (cb94eeb) to head (49f4380).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
consensus/src/marshal/coding/mod.rs 97.29% 1 Missing ⚠️
consensus/src/marshal/mocks/verifying.rs 75.00% 1 Missing ⚠️
@@           Coverage Diff            @@
##             main    #3835    +/-   ##
========================================
  Coverage   95.73%   95.74%            
========================================
  Files         473      473            
  Lines      192406   192555   +149     
  Branches     4665     4666     +1     
========================================
+ Hits       184204   184360   +156     
+ Misses       6631     6626     -5     
+ Partials     1571     1569     -2     
Files with missing lines Coverage Δ
consensus/src/lib.rs 0.00% <ø> (ø)
consensus/src/marshal/ancestry.rs 94.59% <100.00%> (-0.28%) ⬇️
consensus/src/marshal/coding/variant.rs 95.08% <100.00%> (+1.33%) ⬆️
consensus/src/marshal/core/mailbox.rs 92.91% <100.00%> (+0.52%) ⬆️
consensus/src/marshal/mocks/harness.rs 98.75% <100.00%> (+<0.01%) ⬆️
consensus/src/marshal/standard/mod.rs 96.80% <100.00%> (+0.03%) ⬆️
consensus/src/marshal/standard/variant.rs 100.00% <100.00%> (ø)
consensus/src/marshal/coding/mod.rs 96.15% <97.29%> (+0.19%) ⬆️
consensus/src/marshal/mocks/verifying.rs 89.61% <75.00%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb94eeb...49f4380. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants