Skip to content

[marshal] Assert AncestryStream Correctness (+ Fix Reshare Example)#3845

Merged
patrick-ogrady merged 11 commits into
marshal-state-syncfrom
state-sync-stream-assert
May 20, 2026
Merged

[marshal] Assert AncestryStream Correctness (+ Fix Reshare Example)#3845
patrick-ogrady merged 11 commits into
marshal-state-syncfrom
state-sync-stream-assert

Conversation

@patrick-ogrady
Copy link
Copy Markdown
Contributor

Related: #3828

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 20, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
commonware-mcp 3409e8a May 20 2026, 08:27 PM

Comment thread examples/reshare/src/orchestrator/actor.rs Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026

Benchmark results

Tip

PASSED: No benchmark exceeded the regression threshold.

Benchmark comparison table
Benchmark Baseline (main) Current Delta Threshold Status
qmdb::merkleize/variant=any::unordered::fixed::mmr keys=10000 ch=false sync=false 1.555 ms 1.571 ms +1.04% 10.00% ✅ PASS
qmdb::merkleize/variant=current::ordered::fixed::mmb chunk=256 keys=10000 ch=true sync=false 3.044 ms 3.100 ms +1.83% 10.00% ✅ PASS

Baseline commit(s): 25bd84194fab

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 20, 2026

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3409e8a
Status: ✅  Deploy successful!
Preview URL: https://bee52c6b.monorepo-eu0.pages.dev
Branch Preview URL: https://state-sync-stream-assert.monorepo-eu0.pages.dev

View logs

Comment thread examples/reshare/src/orchestrator/actor.rs Outdated
Comment thread consensus/src/marshal/ancestry.rs
@patrick-ogrady patrick-ogrady changed the title [marshal] Assert AncestryStream Conrrectness [marshal] Assert AncestryStream Correctness (+ Fix Reshare Example) May 20, 2026
Comment thread examples/reshare/src/dkg/actor.rs Outdated
Comment thread examples/reshare/src/orchestrator/actor.rs Outdated
Comment thread examples/reshare/src/dkg/state.rs Outdated
@patrick-ogrady patrick-ogrady merged commit 691eba9 into marshal-state-sync May 20, 2026
166 of 172 checks passed
@patrick-ogrady patrick-ogrady deleted the state-sync-stream-assert branch May 20, 2026 20:29
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 96.93878% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (marshal-state-sync@d917919). Learn more about missing BASE report.

Files with missing lines Patch % Lines
consensus/src/marshal/ancestry.rs 94.44% 3 Missing ⚠️
@@                  Coverage Diff                  @@
##             marshal-state-sync    #3845   +/-   ##
=====================================================
  Coverage                      ?   95.75%           
=====================================================
  Files                         ?      474           
  Lines                         ?   193419           
  Branches                      ?     4695           
=====================================================
  Hits                          ?   185205           
  Misses                        ?     6625           
  Partials                      ?     1589           
Files with missing lines Coverage Δ
consensus/src/marshal/coding/mod.rs 96.31% <100.00%> (ø)
consensus/src/marshal/coding/variant.rs 95.52% <100.00%> (ø)
consensus/src/marshal/config.rs 100.00% <ø> (ø)
consensus/src/marshal/standard/mod.rs 96.87% <100.00%> (ø)
consensus/src/marshal/standard/variant.rs 100.00% <100.00%> (ø)
consensus/src/simplex/mod.rs 98.48% <100.00%> (ø)
consensus/src/marshal/ancestry.rs 92.30% <94.44%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d917919...3409e8a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant