Skip to content

[parallel] Wrap Blocking Calls in Async#3846

Draft
patrick-ogrady wants to merge 11 commits into
mainfrom
simple-strategy
Draft

[parallel] Wrap Blocking Calls in Async#3846
patrick-ogrady wants to merge 11 commits into
mainfrom
simple-strategy

Conversation

@patrick-ogrady
Copy link
Copy Markdown
Contributor

No description provided.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 20, 2026

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 87b69b5
Status: ✅  Deploy successful!
Preview URL: https://5940318e.monorepo-eu0.pages.dev
Branch Preview URL: https://simple-strategy.monorepo-eu0.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 20, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
commonware-mcp 87b69b5 May 21 2026, 06:52 PM

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026

Benchmark results

Tip

PASSED: No benchmark exceeded the regression threshold.

Benchmark comparison table
Benchmark Baseline (main) Current Delta Threshold Status
qmdb::merkleize/variant=any::unordered::fixed::mmr keys=10000 ch=false sync=false 1.623 ms 1.600 ms -1.38% 10.00% ✅ PASS
qmdb::merkleize/variant=current::ordered::fixed::mmb chunk=256 keys=10000 ch=true sync=false 3.075 ms 3.093 ms +0.59% 10.00% ✅ PASS

Baseline commit(s): edc5cced171c

timer.observe(self.context.as_ref());
debug!(view = %updated_view, "constructed notarization, forwarding to voter");

// Forward notarization to voter
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block together?

# Conflicts:
#	consensus/src/marshal/coding/marshaled.rs
#	consensus/src/marshal/core/actor.rs
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

❌ Patch coverage is 94.93088% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.76%. Comparing base (edc5cce) to head (87b69b5).

Files with missing lines Patch % Lines
consensus/src/simplex/actors/batcher/actor.rs 93.18% 4 Missing and 5 partials ⚠️
consensus/src/marshal/coding/shards/engine.rs 97.03% 2 Missing and 2 partials ⚠️
consensus/src/simplex/actors/batcher/round.rs 89.28% 3 Missing ⚠️
consensus/src/simplex/actors/resolver/actor.rs 94.11% 0 Missing and 3 partials ⚠️
consensus/src/marshal/coding/marshaled.rs 84.61% 2 Missing ⚠️
consensus/src/marshal/core/actor.rs 97.91% 0 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##             main    #3846      +/-   ##
==========================================
- Coverage   95.77%   95.76%   -0.01%     
==========================================
  Files         486      486              
  Lines      200338   200597     +259     
  Branches     4858     4867       +9     
==========================================
+ Hits       191872   192108     +236     
- Misses       6834     6850      +16     
- Partials     1632     1639       +7     
Files with missing lines Coverage Δ
consensus/src/marshal/core/delivery.rs 100.00% <100.00%> (ø)
consensus/src/simplex/actors/batcher/verifier.rs 99.70% <100.00%> (+<0.01%) ⬆️
consensus/src/marshal/core/actor.rs 92.77% <97.91%> (+0.29%) ⬆️
consensus/src/marshal/coding/marshaled.rs 83.18% <84.61%> (-0.04%) ⬇️
consensus/src/simplex/actors/batcher/round.rs 90.00% <89.28%> (-5.04%) ⬇️
consensus/src/simplex/actors/resolver/actor.rs 83.58% <94.11%> (+5.18%) ⬆️
consensus/src/marshal/coding/shards/engine.rs 96.68% <97.03%> (-0.01%) ⬇️
consensus/src/simplex/actors/batcher/actor.rs 93.46% <93.18%> (-0.43%) ⬇️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc5cce...87b69b5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@patrick-ogrady
Copy link
Copy Markdown
Contributor Author

On alto (global, 50 nodes), this reduces view latency by a few ms:

(without)

image

(with)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant