Skip to content

[marshal] State Sync Review#3847

Merged
patrick-ogrady merged 11 commits into
marshal-state-syncfrom
marshal-state-sync-review
May 21, 2026
Merged

[marshal] State Sync Review#3847
patrick-ogrady merged 11 commits into
marshal-state-syncfrom
marshal-state-sync-review

Conversation

@patrick-ogrady
Copy link
Copy Markdown
Contributor

No description provided.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 21, 2026

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3c42574
Status: ✅  Deploy successful!
Preview URL: https://5cbb8f17.monorepo-eu0.pages.dev
Branch Preview URL: https://marshal-state-sync-review.monorepo-eu0.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 21, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
commonware-mcp 3c42574 May 21 2026, 06:00 AM

Comment thread consensus/src/marshal/core/actor.rs Outdated
Comment thread consensus/src/marshal/core/actor.rs Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

Benchmark results

Tip

PASSED: No benchmark exceeded the regression threshold.

Benchmark comparison table
Benchmark Baseline (main) Current Delta Threshold Status
qmdb::merkleize/variant=any::unordered::fixed::mmr keys=10000 ch=false sync=false 1.696 ms 1.551 ms -8.57% 10.00% ✅ PASS
qmdb::merkleize/variant=current::ordered::fixed::mmb chunk=256 keys=10000 ch=true sync=false 3.183 ms 3.018 ms -5.20% 10.00% ✅ PASS

Baseline commit(s): 7d9df6f7e790

Copy link
Copy Markdown
Contributor Author

@patrick-ogrady patrick-ogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty close!

Comment thread consensus/src/marshal/coding/variant.rs Outdated
Comment thread consensus/src/marshal/core/actor.rs
Comment thread consensus/src/marshal/core/actor.rs Outdated
Comment thread consensus/src/marshal/core/actor.rs
Comment thread consensus/src/marshal/core/actor.rs
Comment thread consensus/src/marshal/standard/variant.rs Outdated
Comment thread consensus/src/marshal/ancestry.rs Outdated
Comment thread consensus/src/simplex/actors/voter/actor.rs Outdated
Comment thread consensus/src/simplex/actors/voter/mod.rs
@patrick-ogrady
Copy link
Copy Markdown
Contributor Author

bugbot run

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit b6fd55b. Configure here.

@patrick-ogrady
Copy link
Copy Markdown
Contributor Author

bugbot run

@patrick-ogrady patrick-ogrady marked this pull request as ready for review May 21, 2026 06:06
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 3c42574. Configure here.

@patrick-ogrady patrick-ogrady merged commit 88820f2 into marshal-state-sync May 21, 2026
175 checks passed
@patrick-ogrady patrick-ogrady deleted the marshal-state-sync-review branch May 21, 2026 06:28
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

❌ Patch coverage is 96.37804% with 64 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.78%. Comparing base (ee808f0) to head (3c42574).
⚠️ Report is 4 commits behind head on marshal-state-sync.

Files with missing lines Patch % Lines
consensus/src/marshal/core/actor.rs 94.92% 12 Missing and 9 partials ⚠️
consensus/src/marshal/core/floor.rs 91.94% 14 Missing and 5 partials ⚠️
consensus/src/marshal/core/subscriptions.rs 95.47% 9 Missing ⚠️
consensus/src/marshal/standard/mod.rs 97.29% 4 Missing and 4 partials ⚠️
consensus/src/simplex/actors/voter/mod.rs 98.47% 3 Missing and 3 partials ⚠️
consensus/src/marshal/core/variant.rs 97.82% 0 Missing and 1 partial ⚠️
@@                  Coverage Diff                   @@
##           marshal-state-sync    #3847      +/-   ##
======================================================
+ Coverage               95.76%   95.78%   +0.01%     
======================================================
  Files                     481      479       -2     
  Lines                  198455   195043    -3412     
  Branches                 4836     4708     -128     
======================================================
- Hits                   190055   186817    -3238     
+ Misses                   6787     6628     -159     
+ Partials                 1613     1598      -15     
Files with missing lines Coverage Δ
consensus/src/marshal/ancestry.rs 93.02% <100.00%> (+0.71%) ⬆️
consensus/src/marshal/coding/mod.rs 96.22% <100.00%> (ø)
consensus/src/marshal/core/acks.rs 100.00% <100.00%> (ø)
consensus/src/marshal/core/delivery.rs 100.00% <100.00%> (ø)
consensus/src/marshal/mocks/harness.rs 98.77% <100.00%> (ø)
consensus/src/simplex/actors/voter/actor.rs 97.46% <100.00%> (+0.02%) ⬆️
consensus/src/simplex/config.rs 100.00% <ø> (ø)
consensus/src/simplex/mod.rs 98.47% <100.00%> (ø)
consensus/src/marshal/core/variant.rs 97.82% <97.82%> (ø)
consensus/src/simplex/actors/voter/mod.rs 92.12% <98.47%> (+0.41%) ⬆️
... and 4 more

... and 33 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee808f0...3c42574. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants