Skip to content

[marshal] Add Regression Test for Pending Acks#3848

Merged
patrick-ogrady merged 5 commits into
mainfrom
marshal-tweaks
May 21, 2026
Merged

[marshal] Add Regression Test for Pending Acks#3848
patrick-ogrady merged 5 commits into
mainfrom
marshal-tweaks

Conversation

@patrick-ogrady
Copy link
Copy Markdown
Contributor

@patrick-ogrady patrick-ogrady commented May 21, 2026

Related: #3828

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 21, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
commonware-mcp 3bc4421 May 21 2026, 08:18 AM

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

Benchmark results

Tip

PASSED: No benchmark exceeded the regression threshold.

Benchmark comparison table
Benchmark Baseline (main) Current Delta Threshold Status
qmdb::merkleize/variant=any::unordered::fixed::mmr keys=10000 ch=false sync=false 1.565 ms 1.567 ms +0.18% 10.00% ✅ PASS
qmdb::merkleize/variant=current::ordered::fixed::mmb chunk=256 keys=10000 ch=true sync=false 3.028 ms 3.034 ms +0.21% 10.00% ✅ PASS

Baseline commit(s): 34f1f8e40310

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 21, 2026

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3bc4421
Status: ✅  Deploy successful!
Preview URL: https://6ec44064.monorepo-eu0.pages.dev
Branch Preview URL: https://marshal-tweaks.monorepo-eu0.pages.dev

View logs

@patrick-ogrady patrick-ogrady merged commit d8589a0 into main May 21, 2026
176 checks passed
@patrick-ogrady patrick-ogrady deleted the marshal-tweaks branch May 21, 2026 08:28
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

❌ Patch coverage is 97.18310% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.77%. Comparing base (c0f7a04) to head (3bc4421).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
consensus/src/marshal/standard/mod.rs 97.16% 5 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##             main    #3848      +/-   ##
==========================================
- Coverage   95.77%   95.77%   -0.01%     
==========================================
  Files         486      486              
  Lines      199578   200338     +760     
  Branches     4851     4858       +7     
==========================================
+ Hits       191147   191870     +723     
- Misses       6806     6837      +31     
- Partials     1625     1631       +6     
Files with missing lines Coverage Δ
consensus/src/marshal/core/actor.rs 92.47% <100.00%> (+<0.01%) ⬆️
consensus/src/marshal/standard/mod.rs 97.41% <97.16%> (+0.01%) ⬆️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0f7a04...3bc4421. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant