Skip to content

[cryptography] Clarify DKG differences#3854

Merged
patrick-ogrady merged 7 commits into
mainfrom
ck/doc-dkg
May 22, 2026
Merged

[cryptography] Clarify DKG differences#3854
patrick-ogrady merged 7 commits into
mainfrom
ck/doc-dkg

Conversation

@cronokirby
Copy link
Copy Markdown
Collaborator

Removes a blurb in dkg about how asynchrony is future work, referencing the current golden impl instead, and adds top level docs about the two DKG protocols.

Removes a blurb in dkg about how asynchrony is future work,
referencing the current golden impl instead, and adds top level
docs about the two DKG protocols.
@cronokirby cronokirby self-assigned this May 21, 2026
@cronokirby cronokirby moved this to Ready for Review in Tracker May 21, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 21, 2026

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 343be26
Status: ✅  Deploy successful!
Preview URL: https://3763735c.monorepo-eu0.pages.dev
Branch Preview URL: https://ck-doc-dkg.monorepo-eu0.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 21, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
commonware-mcp 343be26 May 22 2026, 06:42 AM

Comment thread cryptography/src/bls12381/dkg.rs Outdated
Comment thread cryptography/src/bls12381/mod.rs Outdated
Comment thread cryptography/src/bls12381/mod.rs Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

Benchmark results

Tip

PASSED: No benchmark exceeded the regression threshold.

Benchmark comparison table
Benchmark Baseline (main) Current Delta Threshold Status
qmdb::merkleize/variant=any::unordered::fixed::mmr keys=10000 ch=false sync=false 1.701 ms 1.588 ms -6.65% 10.00% ✅ PASS
qmdb::merkleize/variant=current::ordered::fixed::mmb chunk=256 keys=10000 ch=true sync=false 3.195 ms 3.106 ms -2.79% 10.00% ✅ PASS

Baseline commit(s): 2a51df34cbcc

@patrick-ogrady patrick-ogrady merged commit 225574b into main May 22, 2026
175 of 176 checks passed
@patrick-ogrady patrick-ogrady deleted the ck/doc-dkg branch May 22, 2026 06:56
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Tracker May 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.76%. Comparing base (edc5cce) to head (343be26).
⚠️ Report is 2 commits behind head on main.

@@            Coverage Diff             @@
##             main    #3854      +/-   ##
==========================================
- Coverage   95.77%   95.76%   -0.01%     
==========================================
  Files         486      486              
  Lines      200338   200680     +342     
  Branches     4858     4858              
==========================================
+ Hits       191872   192186     +314     
- Misses       6834     6861      +27     
- Partials     1632     1633       +1     
Files with missing lines Coverage Δ
...ensus/src/simplex/scheme/bls12381_threshold/vrf.rs 97.68% <100.00%> (+0.22%) ⬆️
...graphy/src/bls12381/certificate/threshold/mocks.rs 100.00% <ø> (ø)
...tography/src/bls12381/certificate/threshold/mod.rs 98.45% <ø> (ø)
cryptography/src/bls12381/dkg/feldman_desmedt.rs 93.41% <ø> (ø)
...raphy/src/bls12381/dkg/golden/evrf/bandersnatch.rs 90.75% <ø> (ø)
cryptography/src/bls12381/dkg/golden/evrf/mod.rs 90.11% <ø> (ø)
cryptography/src/bls12381/dkg/golden/mod.rs 96.57% <ø> (ø)
...ptography/src/bls12381/primitives/ops/threshold.rs 98.26% <ø> (ø)

... and 36 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc5cce...343be26. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants